这是indexloc提供的服务，不要输入任何密码
Skip to content

Support order by Un-deleted data #2587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 24, 2025
Merged

Support order by Un-deleted data #2587

merged 14 commits into from
Jul 24, 2025
+51 −7

Conversation

dhercher
Copy link
Contributor

Adding a feature to allow the isDeleted flag to be included in the order by keys

@dhercher
Update DataStreamToSQL.java
fd3b20c 
adding getOrderByIncludesIsDeleted
@dhercher dhercher requested a review from a team as a code owner July 23, 2025 19:28
@dhercher
Update DatastreamRow.java
18a471c 
adding isdeleted support
@dhercher dhercher requested a review from a team as a code owner July 23, 2025 23:56
@codecov Codecov
Copy link

codecov bot commented Jul 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 4.16667% with 23 lines in your changes missing coverage. Please review.

Project coverage is 49.85%. Comparing base (72d02e4) to head (e7b2e91).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...oogle/cloud/teleport/v2/utils/DatastreamToDML.java 8.33% 11 Missing ⚠️
...google/cloud/teleport/v2/transforms/CreateDml.java 0.00% 6 Missing ⚠️
...d/teleport/v2/datastream/values/DatastreamRow.java 0.00% 5 Missing ⚠️
...e/cloud/teleport/v2/templates/DataStreamToSQL.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2587      +/-   ##
============================================
- Coverage     49.89%   49.85%   -0.04%     
- Complexity     4877     5229     +352     
============================================
  Files           952      952              
  Lines         58224    58242      +18     
  Branches       6293     6296       +3     
============================================
- Hits          29048    29037      -11     
- Misses        27103    27128      +25     
- Partials       2073     2077       +4
Components Coverage Δ
spanner-templates 70.08% <ø> (-0.07%) ⬇️
spanner-import-export 68.45% <ø> (-0.18%) ⬇️
spanner-live-forward-migration 79.33% <ø> (ø)
spanner-live-reverse-replication 77.03% <ø> (ø)
spanner-bulk-migration 88.23% <ø> (ø)
Files with missing lines Coverage Δ
...e/cloud/teleport/v2/templates/DataStreamToSQL.java 4.34% <0.00%> (-0.07%) ⬇️
...d/teleport/v2/datastream/values/DatastreamRow.java 38.23% <0.00%> (-2.39%) ⬇️
...google/cloud/teleport/v2/transforms/CreateDml.java 0.00% <0.00%> (ø)
...oogle/cloud/teleport/v2/utils/DatastreamToDML.java 9.12% <8.33%> (+0.11%) ⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 24, 2025
@danowar2
Copy link

Thanks for the update

@danowar2
Copy link

This community allowed me to get a great place to get a great place to get a great job

@dhercher dhercher requested a review from udbhavchugh July 24, 2025 15:41
@dhercher dhercher merged commit 76e18cf into main Jul 24, 2025
45 of 47 checks passed
@dhercher dhercher deleted the dhercher-patch-1 branch July 24, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udbhavchugh udbhavchugh udbhavchugh approved these changes

@pratickchokhani pratickchokhani Awaiting requested review from pratickchokhani pratickchokhani is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@darshan-sj darshan-sj Awaiting requested review from darshan-sj darshan-sj is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

Assignees
No one assigned
Labels
improvement size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhercher @danowar2 @udbhavchugh