这是indexloc提供的服务，不要输入任何密码
Skip to content

Update FormatDatastreamJsonToJson.java #2569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 18, 2025
Merged

Update FormatDatastreamJsonToJson.java #2569

merged 7 commits into from
Jul 18, 2025
+15 −3

Conversation

dhercher
Copy link
Contributor

adding postgres source metadata details to datastream json reader

@dhercher
Update FormatDatastreamJsonToJson.java
cde786f 
adding postgres source metadata details to datastream json reader
@dhercher dhercher requested review from a team as code owners July 17, 2025 22:06
@codecov Codecov
Copy link

codecov bot commented Jul 17, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 49.74%. Comparing base (19810af) to head (85684c5).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...astream/transforms/FormatDatastreamJsonToJson.java 27.27% 5 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #2569      +/-   ##
============================================
- Coverage     49.75%   49.74%   -0.02%     
- Complexity     4826     5178     +352     
============================================
  Files           948      948              
  Lines         57949    57959      +10     
  Branches       6259     6262       +3     
============================================
- Hits          28834    28830       -4     
- Misses        27069    27077       +8     
- Partials       2046     2052       +6
Components Coverage Δ
spanner-templates 70.13% <ø> (-0.02%) ⬇️
spanner-import-export 68.61% <ø> (-0.04%) ⬇️
spanner-live-forward-migration 79.22% <ø> (ø)
spanner-live-reverse-replication 77.80% <ø> (ø)
spanner-bulk-migration 87.99% <ø> (ø)
Files with missing lines Coverage Δ
...astream/transforms/FormatDatastreamJsonToJson.java 53.90% <27.27%> (-2.88%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dhercher dhercher added the addition New feature or request label Jul 17, 2025
renzokuken
renzokuken previously approved these changes Jul 17, 2025
View reviewed changes
@dhercher dhercher added improvement and removed addition New feature or request labels Jul 17, 2025
@dhercher dhercher requested a review from renzokuken July 18, 2025 07:42
dhercher added 2 commits July 18, 2025 10:07
@dhercher
Update FormatDatastreamJsonToJson.java
375c3d9 
shifting fields to cover default since read method was broken in new sources
@dhercher
Update FormatDatastreamJsonToJsonTest.java
85684c5 
fixing tests
@dhercher dhercher merged commit 7da117e into main Jul 18, 2025
45 of 47 checks passed
@dhercher dhercher deleted the dhercher-patch-2 branch July 18, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renzokuken renzokuken renzokuken approved these changes

@oferhandel-google oferhandel-google oferhandel-google approved these changes

@pratickchokhani pratickchokhani Awaiting requested review from pratickchokhani pratickchokhani is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

@VardhanThigle VardhanThigle Awaiting requested review from VardhanThigle VardhanThigle is a code owner automatically assigned from GoogleCloudPlatform/spanner-migrations-team

Assignees
No one assigned
Labels
improvement size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhercher @renzokuken @oferhandel-google