Fix negative value modulo bug #2567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javaallows negatives in modulo which caused double the number of threads. shifting to fix to the expected number and moving to 15 threads for accidental backwards compatibility
remove import
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2567 +/- ##
============================================
- Coverage 49.76% 49.72% -0.04%
- Complexity 4825 5175 +350
============================================
Files 948 948
Lines 57938 57948 +10
Branches 6259 6259
============================================
- Hits 28831 28817 -14
- Misses 27060 27081 +21
- Partials 2047 2050 +3
🚀 New features to boost your workflow:
|
renzokuken
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
javaallows negatives in modulo which caused double the number of threads. shifting to fix to the expected number and moving to 15 threads for accidental backwards compatibility