这是indexloc提供的服务,不要输入任何密码
Skip to content

Improve and regenerate terraform templates #2438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

prawilny
Copy link

This PR is a byproduct of this review.

Apart from changing the templates, I regenerated their instantiations and the docs as documented in code-contributions.md.

Note that I regenerated the v2 templates using the following command:

mvn clean prepare-package \
  -DskipTests \
  -PtemplatesTerraform \
  -pl v2/astradb-to-bigquery,v2/azure-eventhub-to-pubsub,v2/bigtable-changestreams-to-hbase,v2/bigtable-common,v2/bigquery-to-bigtable,v2/bigquery-to-parquet,v2/cdc-parent,v2/common,v2/dataplex,v2/datastream-common,v2/datastream-to-bigquery,v2/datastream-mongodb-to-firestore,v2/datastream-to-mongodb,v2/datastream-to-postgres,v2/datastream-to-spanner,v2/datastream-to-sql,v2/elasticsearch-common,v2/file-format-conversion,v2/gcs-to-sourcedb,v2/googlecloud-to-elasticsearch,v2/googlecloud-to-googlecloud,v2/googlecloud-to-mongodb,v2/googlecloud-to-neo4j,v2/googlecloud-to-splunk,v2/google-ads-to-googlecloud,v2/jdbc-common,v2/jdbc-and-googlecloud,v2/jms-to-pubsub,v2/kafka-common,v2/kafka-to-bigquery,v2/kafka-to-gcs,v2/kafka-to-kafka,v2/kafka-to-pubsub,v2/kinesis-to-pubsub,v2/kudu-to-bigquery,v2/mongodb-to-googlecloud,v2/mqtt-to-pubsub,v2/mysql-to-googlecloud,v2/oracle-to-googlecloud,v2/postgresql-to-googlecloud,v2/pubsub-binary-to-bigquery,v2/pubsub-cdc-to-bigquery,v2/pubsub-to-jms,v2/pubsub-to-kafka,v2/pubsub-to-mongodb,v2/pubsub-to-redis,v2/sourcedb-to-spanner,v2/spanner-change-streams-to-sharded-file-sink,v2/spanner-common,v2/spanner-custom-shard,v2/spanner-migrations-sdk,v2/spanner-to-sourcedb,v2/sqlserver-to-googlecloud,v2/streaming-data-generator,v2/googlecloud-to-clickhouse,v2/clickhouse-common,v2/real-spanner-service,v2/failure-injected-spanner-service,v2/failure-injection-policies -am

since

mvn clean prepare-package \
  -DskipTests \
  -PtemplatesTerraform \
  -pl v2 -am

regenerates no templates and the commands from code-contributions.md only regenerates the templates from v2/googlecloud-to-googlecloud.

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.70%. Comparing base (a6f23b5) to head (eb366d3).
Report is 32 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2438      +/-   ##
============================================
- Coverage     49.73%   49.70%   -0.03%     
- Complexity     4792     5140     +348     
============================================
  Files           938      938              
  Lines         57337    57337              
  Branches       6209     6209              
============================================
- Hits          28519    28502      -17     
- Misses        26776    26789      +13     
- Partials       2042     2046       +4     
Components Coverage Δ
spanner-templates 70.52% <ø> (-0.07%) ⬇️
spanner-import-export 68.48% <ø> (-0.17%) ⬇️
spanner-live-forward-migration 78.67% <ø> (ø)
spanner-live-reverse-replication 80.60% <ø> (ø)
spanner-bulk-migration 87.75% <ø> (ø)

see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants