Guard INP attribution no entries #636
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you clarify how it's possible for there to be an INP with no entries?
With all of the other metrics, it's possible for there to be a metric event with no entries:
But these cases do not apply to INP. Is there another case I'm not aware of? |
|
OK so it was do to a bug in my soft navs branch. I was resetting INP to 0 instead of -1 and so it was attempting to report that 0 (like it would CLS) but without any entries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #639
INP attribution doesn't currently check if there are any
evententries, whereas all the other metrics do.This can result in an error when attempting to access the first entry.
This does require making each of the
attributionfields optional (similar to CLS), but given this can only happen when it would error anyway I think that's OK without a major change.