Prevents redirects in the find_robots_txt check #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjledoux
suggested changes
Feb 5, 2024
Verified that changing RwsCheck to allow redirects fails test
|
Looks like you've passed all of the checks! |
cfredric
pushed a commit
to cfredric/chrome-first-party-sets
that referenced
this pull request
Mar 11, 2024
* Do not allow redirects on robots.txt check. * Assert no redirects in tests * Update tests based on review feedback Verified that changing RwsCheck to allow redirects fails test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #246 by explicitly disabling redirects on the
find_robots_txtcheck. Adds asserts that this is the case in the tests.This allows for the case where a service domain redirects to another domain that does not have the
X-Robots-Tag.This shouldn't change the behavior of non-redirecting which must either 4xx or 5xx when the home page is hit.