-
-
Notifications
You must be signed in to change notification settings - Fork 96
[talker_chopper_logger] Add TalkerKeys registration #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR bumps the dev version across all Talker packages to 5.0.0-dev.11, enriches the TalkerChopperLogger interceptor by registering HTTP log keys at initialization, and updates the CHANGELOGs to reflect the new release and contribution. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Frezyx - I've reviewed your changes - here's some feedback:
- Fix the copy-paste errors in the CHANGELOG.md files—most of them mention talker_chopper_logger even in unrelated packages so they should reference their own package name.
- Consider guarding or relocating the TalkerKey.registration call so you don’t re-register the same keys every time an interceptor instance is created.
- To prevent manual drift in version bumps across all READMEs, examples, and pubspecs, think about adding a simple script or tool to automate those updates.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Fix the copy-paste errors in the CHANGELOG.md files—most of them mention talker_chopper_logger even in unrelated packages so they should reference their own package name.
- Consider guarding or relocating the TalkerKey.registration call so you don’t re-register the same keys every time an interceptor instance is created.
- To prevent manual drift in version bumps across all READMEs, examples, and pubspecs, think about adding a simple script or tool to automate those updates.
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Bump the project to 5.0.0-dev.11, sync dependency versions across packages, examples, and documentation, and add HTTP TalkerKeys registration in the Chopper logger interceptor
New Features:
Enhancements:
Documentation:
Chores: