这是indexloc提供的服务，不要输入任何密码
Skip to content

fix: add missing error and exception details to console logs #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: add missing error and exception details to console logs #398

wants to merge 1 commit into from

Conversation

Zekfad
Copy link

@Zekfad Zekfad commented Jul 16, 2025 •
edited by sourcery-ai bot
Loading

  • Bugfix for missing error and exception details
    Describe the bug
    TalkerData#generateTextMessage is missing displayException and displayError, uses message instead of displayMessage which could cause "null" string in logs (intended?).
    TalkerLog#generateTextMessage is missing displayError which prevents printing errors to console log.

    To Reproduce

    • Add custom log with error.
    • Error is not printed.

    Expected behavior

    • Error should be included in output same as exception.

Summary by Sourcery

Ensure that error and exception details, along with the proper displayMessage, are included in console log output generated by TalkerData and TalkerLog

Bug Fixes:

  • Replace raw message with displayMessage and include missing displayException and displayError in TalkerData generateTextMessage
  • Add missing displayError to TalkerLog generateTextMessage so errors are printed to console logs

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jul 16, 2025 •
edited
Loading

Reviewer's Guide

Update generateTextMessage implementations in TalkerData and TalkerLog to include missing error and exception details and replace raw message usage with displayMessage, ensuring full context is logged.

Class diagram for updated TalkerData and TalkerLog message generation

classDiagram
    class TalkerData {
      +String displayTitleWithTime(TimeFormat timeFormat)
      +String displayMessage
      +String displayException
      +String displayError
      +String displayStackTrace
      +String generateTextMessage(TimeFormat timeFormat)
    }
    class TalkerLog {
      +String generateTextMessage(TimeFormat timeFormat)
    }
    TalkerLog --|> TalkerData
Loading

File-Level Changes

Change Details Files
Enhanced TalkerData log formatting to include error and exception details
  • Replaced message property with displayMessage
  • Added displayException before error output
  • Added displayError before stack trace
 packages/talker/lib/src/models/talker_data.dart
Extended TalkerLog formatting to include missing error output
  • Appended displayError to the log template
 packages/talker/lib/src/models/talker_log.dart

Possibly linked issues

  • Fix logs formating #1: PR fixes missing error/exception fields in TalkerLog, which resolves the empty fields in DioErrorLog issue.
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Zekfad - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Zekfad Zekfad mentioned this pull request Jul 16, 2025
Closed
@Frezyx
Copy link
Owner

Frezyx commented Jul 20, 2025

Hello @Zekfad !
Could you please fix tests before we will merge it ?

@Frezyx Frezyx added enhancement New feature or request core Related to core packages (talker, talker_logger, talker_flutter) console Related to console output tests Related to tests and test coverage labels Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@Frezyx Frezyx Frezyx approved these changes

Assignees
No one assigned
Labels
console Related to console output core Related to core packages (talker, talker_logger, talker_flutter) enhancement New feature or request tests Related to tests and test coverage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zekfad @Frezyx