这是indexloc提供的服务，不要输入任何密码
Skip to content

More flexible interaction with custom logs (TalkerLogType -> String key) #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 22, 2024
Merged

More flexible interaction with custom logs (TalkerLogType -> String key) #272

merged 20 commits into from
Nov 22, 2024

Conversation

yelmuratoff
Copy link
Contributor

@yelmuratoff yelmuratoff commented Oct 28, 2024 •
edited
Loading

Description

This PR introduces a more flexible approach to interacting with custom logs.

Key Features

  1. Custom Key Support:

    • Adds the ability to define a custom key when creating a custom log.
    • Updates theme and settings parameters to accept a map with a key (instead of an enum) for matching colors.

  2. Improved Customization:

    • This change is especially useful for users of the talker and talker_flutter libraries who implement their own version of the Talker Screen.
    • Currently, custom logs default to a null key, which limits flexibility. This PR addresses that limitation.

Additional Notes

  • A "Good" log has been added as an example for demonstration purposes.

This enhancement ensures a smoother and more customizable experience for developers extending the library.

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.22%. Comparing base (542b9b8) to head (01ac2bc).

Files with missing lines Patch % Lines
packages/talker/lib/src/talker_key.dart 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff             @@
##            master     #272      +/-   ##
===========================================
- Coverage   100.00%   97.22%   -2.78%     
===========================================
  Files            6       14       +8     
  Lines          185      324     +139     
===========================================
+ Hits           185      315     +130     
- Misses           0        9       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@yelmuratoff yelmuratoff closed this Nov 5, 2024
@yelmuratoff yelmuratoff reopened this Nov 6, 2024
@Frezyx Frezyx added enhancement New feature or request consideration Awaiting a decision on implementation awaiting On the list for consideration or merge core Related to core packages (talker, talker_logger, talker_flutter) labels Nov 12, 2024
@Frezyx Frezyx linked an issue Nov 13, 2024 that may be closed by this pull request
Add color customization for TalkerLog in TalkerScreen #252
Closed
Frezyx
Frezyx requested changes Nov 20, 2024
View reviewed changes
@Frezyx Frezyx added work_in_progress Сurrently under work console Related to console output and removed consideration Awaiting a decision on implementation awaiting On the list for consideration or merge labels Nov 20, 2024
@Frezyx Frezyx mentioned this pull request Nov 20, 2024
Closed
@Frezyx Frezyx linked an issue Nov 20, 2024 that may be closed by this pull request
no color change for route enum #259
Closed
@yelmuratoff yelmuratoff mentioned this pull request Nov 21, 2024
Closed
@Frezyx Frezyx added release and removed work_in_progress Сurrently under work labels Nov 21, 2024
@Frezyx Frezyx linked an issue Nov 22, 2024 that may be closed by this pull request
Custom colors are not applying for the TalkerScreen. v4.3.4 #250
Closed
@Frezyx Frezyx changed the title Changed the code for more flexible interaction with custom logs. More flexible interaction with custom logs (TalkerLogType -> String key) Nov 22, 2024
@Frezyx Frezyx merged commit 2dd349b into Frezyx:master Nov 22, 2024
3 checks passed
@yelmuratoff
Copy link
Contributor Author

:D

@Frezyx Frezyx mentioned this pull request Nov 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frezyx Frezyx Frezyx approved these changes

Assignees

@Frezyx Frezyx

@yelmuratoff yelmuratoff

Labels
console Related to console output core Related to core packages (talker, talker_logger, talker_flutter) enhancement New feature or request release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no color change for route enum Add color customization for TalkerLog in TalkerScreen Custom colors are not applying for the TalkerScreen. v4.3.4
3 participants
@yelmuratoff @codecov-commenter @Frezyx