这是indexloc提供的服务,不要输入任何密码
Skip to content

Fix reconciler : Expose the contexts #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2021

Conversation

RenaudRohlinger
Copy link
Contributor

@RenaudRohlinger RenaudRohlinger commented Nov 11, 2021

Hello!

Description

To consume the contexts with react reconciler you need to forward the contexts using a "bridge".
See facebook/react#17275
Exposing each context is then necessary if we don't want to wrap all our components twice in that case.

Hello! 
To consume the contexts with react reconcilier you need to forward the contexts using a "bridge".
See facebook/react#17275
Exposing each context is then necessary if we don't want to wrap all our components twice in that case.
@google-cla
Copy link

google-cla bot commented Nov 11, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Nov 11, 2021
@RenaudRohlinger
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Nov 16, 2021
@jhuleatt
Copy link
Collaborator

Hi @RenaudRohlinger, thanks for the PR! While this seems like a rare use case (react-reconciler is "Use it at your own risk" according to the React docs), I think it should be fine to merge if it will benefit you.

@jhuleatt jhuleatt merged commit f654109 into FirebaseExtended:main Nov 16, 2021
@jhuleatt
Copy link
Collaborator

This is available in ReactFire 4.2.1

@RenaudRohlinger
Copy link
Contributor Author

Thanks!

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants