This repository was archived by the owner on Jun 9, 2025. It is now read-only.
Upgrade Firechat to the Firebase 3.x.x SDK #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
examples/anonymous/index.html
Outdated
| <script src="https://www.gstatic.com/firebasejs/3.3.0/firebase.js"></script> | ||
|
|
||
| <!-- Firechat --> | ||
| <!-- <link rel="stylesheet" href="https://cdn.firebase.com/libs/firechat/3.0.0/firechat.min.css" /> |
This was referenced Aug 20, 2016
Closed
This was referenced Aug 20, 2016
Closed
Closed
Contributor
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PLEASE ASSIGN BACK TO ME TO MERGE.
Okay @AbeHaskins, this is ready for you! It's quite large, but I've tested it locally and the example works great. I updated all the docs and also did some repo cleanup to get rid of unneeded files, updated dependencies, etc. Please take a look and assign back to me to do the final merge.