This repository was archived by the owner on May 19, 2025. It is now read-only.
Use resolveRegistration to lookup firebase auth providers. #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build for ember-data 2.10 timed out, restart it please. There are should not be errors. |
|
Thanks for the contribution! |
|
I'm still getting this issue @kolybasov trying to run a basic session open. ember2.12.1 emberfire2.0.6
|
|
@itwasmattgregg this fix is not included into release yet. Ensure you have master branch installed.
or with yarn
|
|
Working! :) Thanks a lot!!! |
ibroadfo
pushed a commit
to ibroadfo/emberfire
that referenced
this pull request
May 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
emberfirewithEmber 2.12authentication is not working.Before code used to find provider class utilized method
lookup. It tries to findfirebase-auth-provider:<provider>factory but nothing was found.Instead we need to use
resolveRegistrationto find auth provider.This PR should fix Issue #493.