fix: quart async test #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kemingy
commented
Sep 17, 2025
- fix bug: Quart, TypeError: The response value type (coroutine) is not valid #449
Signed-off-by: Keming <kemingy94@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Quart async test issues by properly handling async/await patterns in test code and refactoring plugin architecture to support async response validation.
- Converts Quart test functions from sync to async and replaces
asyncio.run()calls with properawaitstatements - Refactors response validation logic from
WerkzeugPluginto framework-specific implementations in Flask and Quart plugins - Adds proper async support for Quart response validation with
awaitcalls for response data access
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_plugin_quart.py | Adds imports for async tests and fixes operator precedence with parentheses |
| tests/quart_imports/dry_plugin_quart.py | Converts all test functions to async and replaces asyncio.run() with await |
| tests/conftest.py | Adds anyio_backend fixture for async test support |
| spectree/plugins/werkzeug_utils.py | Removes validate_response method to be implemented in specific plugins |
| spectree/plugins/quart_plugin.py | Adds async validate_response method with proper await calls |
| spectree/plugins/flask_plugin.py | Adds sync validate_response method moved from WerkzeugPlugin |
| pyproject.toml | Updates version and dependencies |
| pylock.toml | Updates lock file dependencies |
| pylock.legacy.toml | Updates legacy lock file dependencies |
| examples/quart_demo.py | Minor example code update |
| examples/flask_demo.py | Minor example code update |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Keming <kemingy94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.