revert: use validation errors instead of json #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kemingy
commented
Aug 30, 2025
- fix bug: validation error should be serialized by the framework json handler #441
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR reverts changes to use errors() instead of json() method calls for validation error handling across multiple framework plugins, addressing issue #441. The change standardizes error response formatting by switching from JSON serialization to direct error object access.
- Replaces
err.json()calls witherr.errors()across all framework plugins - Removes unnecessary mypy assertions in Flask and Quart plugins
- Updates build environment to specify Python 3.9
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| spectree/plugins/starlette_plugin.py | Changes validation error response from json() to errors() method |
| spectree/plugins/quart_plugin.py | Updates error handling to use errors() and removes mypy assertion |
| spectree/plugins/flask_plugin.py | Switches to errors() method and removes mypy assertion |
| spectree/plugins/falcon_plugin.py | Updates both sync and async validation methods to use errors() |
| build.envd | Specifies Python 3.9 version for uv installation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.