fix: use pylock file to guarantee pydantic v1&v2 env #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <kemingy94@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses pydantic v1 and v2 compatibility issues by implementing lock files to guarantee consistent environments. The change ensures that tests can run reliably against both pydantic versions by using separate lock files for each version.
- Introduces lock files (
pylock.tomlandpylock.legacy.toml) to pin dependencies for pydantic v1 and v2 environments - Updates test configuration to exclude only the necessary schema differences between pydantic versions
- Modifies the test workflow to use the lock files for consistent dependency resolution
Reviewed Changes
Copilot reviewed 9 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Simplified exclusion list in snapshot fixture to only include FormFileUpload schema |
| tests/snapshots/*.json | Updated snapshot files to reflect current schema generation with locked dependencies |
| requirements-legacy.txt | Added constraint file to pin pydantic v1 for legacy testing |
| pyproject.toml | Reformatted dependencies list for better readability |
| Makefile | Updated test target to use lock files and added lock file generation commands |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Keming <kemingy94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.