fix: check the filename to determine if the falcon bodypart is a file #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
Signed-off-by: Keming <kemingy94@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in the Falcon plugin where file upload detection was based on field annotations rather than the actual presence of a file, causing incorrect handling of multipart form data.
- Changed file detection logic to check
part.filenameinstead ofBaseFileannotation - Made the
filefield optional in the test model to reflect the new behavior - Updated test snapshots to reflect the nullable file field in the OpenAPI specification
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| spectree/plugins/falcon_plugin.py | Updated file detection logic to use part.filename check instead of annotation-based detection |
| tests/common.py | Made the file field optional in FormFileUpload test model |
| tests/snapshots/*.json | Updated test snapshots to reflect nullable file field in OpenAPI specs |
| pyproject.toml | Version bump to 1.5.1 |
Comments suppressed due to low confidence (1)
spectree/plugins/falcon_plugin.py:19
- The import for
BaseFileis removed but this could break other parts of the codebase that might still need this import. Ensure thatBaseFileis not used elsewhere in this file or consider keeping the import if it's used by other functionality.
from spectree.plugins.base import BasePlugin, validate_response
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://falcon.readthedocs.io/en/stable/_modules/falcon/media/multipart.html#BodyPart
fix bug: Falcon demo file upload - AttributeError: 'bytes' object has no attribute 'filename' #430 (comment)