PDFium Main Console
| Legend: | Passed | Failed | Running | Exception |
Roll abseil, build, buildtools, libc++/src, and rust
Set the macOS SDK min version, since the latest build roll expects SDK
version 15.x but PDFium bots only have version 14.x.
Add DEPS entries for llvmobjdump, which is needed to successfully
compile with the new rolls.
Roll third_party/abseil-cpp/ 0c63301c7..cae4b6a39 (11 commits)
https://chromium.googlesource.com/chromium/src/third_party/abseil-cpp.git/+log/0c63301c7ef3..cae4b6a3990e
Created with:
roll-dep third_party/abseil-cpp
Roll build/ 328089ed5..777cde7d7 (172 commits)
https://chromium.googlesource.com/chromium/src/build.git/+log/328089ed5e07..777cde7d7982
Created with:
roll-dep build
Roll buildtools/ c618f33e1..5f058f2af (33 commits)
https://chromium.googlesource.com/chromium/src/buildtools.git/+log/c618f33e12dd..5f058f2af10c
Created with:
roll-dep buildtools
Roll third_party/libc++/src/ a01c02c9d..7a36df3ac (135 commits)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxx.git/+log/a01c02c9d4ac..7a36df3acb83
Created with:
roll-dep third_party/libc++/src
Roll tools/rust/ 11d67ba32..c52b68f9d (4 commits)
https://chromium.googlesource.com/chromium/src/tools/rust/+log/11d67ba3289d..c52b68f9dc69
Roll rust llvmorg-21-init-11777-gfd3fecfc : llvmorg-21-init-16348-gbd809ffb
Created with:
roll-dep tools/rust
Change-Id: I9d471afacce3a1b745b907c6422541f82ad8dbb6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133974
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Add a test case for another find text failure
Distill the PDF attached on the bug into a minimal test case. Add an
embedder test case to extract the text. Show that the text is missing a
dash.
Bug: 431824298
Change-Id: I67ce45a17dca191e28a7aa31e9b27cbe339b37b2
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134450
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Rename "pDoc" instances to "doc" in //fxjs and //testing
Mass rename a common variable name to follow Google C++ style. Gemini
did some of the work, with lots of manual interventions.
Bug: 42271580
Change-Id: I5102d8de4e260c5f6aebb86b530c356c7f64be8e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134411
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Avoid calls to deprecated GetIsolate methods
Use the stored isolate instead.
After this landed https://crrev.com/c/6613837 will advance the
deprecation of the methods in the V8 API.
Bug: 427885584
R=tsepez@chromium.org
Change-Id: I7ce29779f5de501ef56c60d5cfdd91772e056d8e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133910
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Clemens Backes <clemensb@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Rename "pDoc" instances to "doc" or "document" in //fpdfsdk and //xfa
Mass rename a common variable name to follow Google C++ style. Gemini
did most of the work, with lots of manual interventions.
Bug: 42271580
Change-Id: Ife26e7a850dafab463516add0040023916c854da
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134310
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Fix a JPEG2000 decoding regression
When neither the PDF nor the JPEG2000 image provides a colorspace, treat
images with 3 channels as though they are RGB and decode them, instead
of giving up and not decoding at all.
This fixes a regression from CL [1], and also reverts the change to
testing/resources/pixel/bug_304_expected.pdf.0.png from that CL.
Although Acrobat Reader rejects the image in the top-left quadrant and
renders it as white, most other PDF implementations will render is as
red.
[1] https://pdfium-review.googlesource.com/104031
Bug: 430651971
Change-Id: I1bc40492671bd0e2bd39cab063d30157dce92e63
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134150
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Move RGB conversion code out of CPDF_DIB::LoadJpxBitmap()
Split part of LoadJpxBitmap() off to ConvertArgbJpxBitmapToRgb().
Change-Id: I1642096718739493efe4ba3f900692922a2d6d3c
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134213
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Simplify CPDF_SecurityHandler::GetUserPassword()
Since `okeylen` has to be equal to `kRequiredOkeyLength` in order for
GetUserPassword() to succeed, rewrite the rest of the function with
that in mind.
Also don't explicitly create a second span from `okeybuf`, when there
already exists a span of `okeybuf`.
Change-Id: I5c0b7247bace2e4fb4e661108cd845fae609fc76
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134291
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Encapsulate more JPEG2000 decoding logic
Even though previous CLs moved some code out to helper functions,
CPDF_DIB::LoadJpxBitmap() is still over 150 lines long. Do another round
of refactoring to move JPEG2000 decoding logic into a separate
JpxDecodeConversion class.
Change-Id: I64d72dcd618210f022f545efee844a46f3f08589
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134212
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Add alternate CJS_Object constructor for testing.
Eases removal of some deprecated V8 methods in a follow-on CL.
Note: not private/friended, since called from a lambda, and the naming
of such is essentially anonymous.
Bug: 427885584
Change-Id: I79cb0810c20e799a708cc88efffea08390222778
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134390
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Make jbig2 data in recently-added file more spec-compliant
The jbig2 file has the page information segment flag byte set to 0x01,
which among other things means a default combination operator of 0
(OR), and the "direct region segments override default combination
operator" flag set to false.
But the generic region had its flags set to 0x02, meaning an XOR
combination operator. This contradicts the page information segment
and is technically invalid per T.88 (see 7.4.8.5 Page segment flags,
page 90, NOTE 1 at the bottom). Change the generic region flags
byte to 0 (OR) to match the page information segment.
No visual effect for PDFium.
Bug: 432742364
Change-Id: Ibf5771f1ec210aea63a350a970bb74b148e65efb
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134330
Reviewed-by: Nico Weber <thakis@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Roll Catapult from a03b70978cc5 to 26075d3aef24 (34 revisions)
https://chromium.googlesource.com/catapult.git/+log/a03b70978cc5..26075d3aef24
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-pdfium
Please CC andyphan@google.com,dhoss@chromium.org,thestig@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: andyphan@google.com
Change-Id: I0bbb32f3a8bd3646d62c2b1d4b25bf3e038189f1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134351
Commit-Queue: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Roll Memory Tools from cc38b4b04fbf to 7f4bdaac14af (1 revision)
https://chromium.googlesource.com/chromium/src/tools/memory.git/+log/cc38b4b04fbf..7f4bdaac14af
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/memory-tools-pdfium
Please CC andyphan@google.com,thestig@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: andyphan@google.com
Change-Id: I7aa584aa670a6c803495e4ff15edcf92215dd83a
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134370
Commit-Queue: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Roll Depot Tools from 909e2921a011 to dd6e72e96818 (41 revisions)
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/909e2921a011..dd6e72e96818
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-pdfium
Please CC andyphan@google.com,thestig@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: andyphan@google.com
Change-Id: I8b65877b82fc8450a394fc838f5f16c6d86ec1f3
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134350
Bot-Commit: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Fix drawing of MMR general regions in JBIG2 images
CJBig2_Context::ParseGenericRegion() calls
page_->ComposeFromWithRect() with grd_->GetReplaceRect() as rect,
but for MMR images, GetReplaceRect() used to always return an
empty rect. That meant we decoded the image but then threw it away
when compositing it to the JBIG2 page.
To fix, set replace_rect_ to the whole bitmap at the end of MMR
decoding, similar to what ProgressiveDecodeArith() does.
Also add a few spec comments to FaxG4GetRow() (which I was reading while
debugging this.)
The test is a hand-draw bitmap that I converted to jbig2 format using
`jbig2` from the zip at https://www.itu.int/rec/T-REC-T.88-201808-I
I ran:
jbig2 -i bitmap -f bmp \
-o jbig2_mmr -F jb2 -ini jbig2-mmr.ini
with this jbig2-mmr.ini:
-Gen -Seg 1
-Gen -Param -Huff 1
I then ran the script linked to in the bug to convert it to a
PDF, and then manually edited it to convert it to .in format.
(Among other things, I ran the file through `xxd` and converted
the stream to /ASCIIHexDecode. I compared dumps from locally-added
hexdumping code and it looks like I didn't mess up the data.)
Bug: 432742364
Change-Id: I9df6c2c233ec89c439d0c813d9b67f64c36cd951
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134270
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@google.com>
Use NOTREACHED() in more switch statements inside cpdf_dib.cpp
Change some switch statements with exhaustive cases to explicitly mark
the unreachable portion as NOTREACHED(), as suggested in
https://abseil.io/tips/147. Also sort the cases to better match the
order they are declared in.
Change-Id: I9962da84315efd95954640886f101f6202975ec1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134211
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Get rid of JpxDecodeAction::kFail enum value
Change the code that deals with enum JpxDecodeAction to use
std::optional instead. Fix a nit in nearby code along the way.
Change-Id: I1b02c29a4e7478203517b17dbbf496afd4359a0e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134210
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
golden_fetch.sh: Tolerate dashes in filenames
Bug: none
Change-Id: Ib4dca04a49548cf18e4bdf7f5cff707c7bb4fdaf
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134230
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Fix decoding of halftone JBIG2 files that use HENABLESKIP
See comments 4-9 on the linked bug for a detailed description of the fixes.
Bug: 431796938
Change-Id: I03991c7e94579bad316f6c4dd322380cd10c2c32
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134090
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@google.com>
Add comments for UNSAFE_TODOs in cpdf_pageobjectholder.cpp
Right now, one can remove these UNSAFE_TODOs and the build will succeed.
Add comments to explain this is waiting for
std::deque::iterator::operator++() to be marked as unsafe.
Change-Id: I37f8d1f9b372fd55e6e29f1ac83116eb08da0481
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134110
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Update test expectations for macOS 14
After updating the x86 Macs CI/CQ builders from macOS 12 to 14, some
tests that check pixel rendering no longer match exactly. Update these
failing test expectations so CI/CQ goes green again.
Bug: 432283590
Change-Id: I81f51ac8e40140bdb463a00ca51daca02de2ecd0
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134130
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Roll goldctl from 2da73c426d1b to 39c6fad2c962
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/goldctl-pdfium
Please CC andyphan@google.com,thestig@chromium.org on the revert to ensure that a human
is aware of the problem.
To file a bug in goldctl: https://issues.skia.org
To file a bug in PDFium: https://crbug.com/pdfium
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: andyphan@google.com
Change-Id: I8394d359b98bd036a6ffd98694ca819fa19b3895
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134030
Commit-Queue: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Update siso_version to f96f46a8e4cf30c097110903d4b71516ef976fb6
Change-Id: Ife9195e620ba59bcd6e6a34e5c15f042fdee3ed7
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133973
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Roll third_party/skia/ e8ef1a27c..34a40032f (89 commits; 9 trivial rolls)
https://skia.googlesource.com/skia.git/+log/e8ef1a27ca8a..34a40032ff0a
Created with:
roll-dep third_party/skia
Change-Id: Id35f4cf6cbcaff6bc745c3f4ff928901e4973e02
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134014
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Update skia/BUILD.gn and roll third_party/skia
https://skia-review.googlesource.com/c/skia/+/1013977 makes PathOps an
optional dependency. Since PDFium needs it, update skia/BUILD.gn to
include it. Then, roll to that commit.
Roll third_party/skia/ ddb944ebd..e8ef1a27c (1 commit)
https://skia.googlesource.com/skia.git/+log/ddb944ebd78c..e8ef1a27ca8a
Created with:
roll-dep third_party/skia
Change-Id: I50e16a6d777fbfd0b71c163adf2e5cdf6e21621d
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134013
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Roll third_party/skia/ df7ab9373..ddb944ebd (134 commits; 20 trivial rolls)
https://skia.googlesource.com/skia.git/+log/df7ab9373bd0..ddb944ebd78c
This is a partial roll, since the next commit introduces linking errors:
https://skia-review.googlesource.com/c/skia/+/1013977.
Created with:
roll-dep third_party/skia
Change-Id: I8b73760c2cee24aad0b89711e983f4ec663f7969
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134012
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Spanify fx_skia_device.cpp and roll third_party/skia
https://skia-review.googlesource.com/c/skia/+/1009933 removes the guard
to use unspanned APIs. Use the new spanned APIs to unblock skia DEPS
rolling. Then, roll to that commit.
Roll third_party/skia/ 9a5e09aac..df7ab9373 (1 commit)
https://skia.googlesource.com/skia.git/+log/9a5e09aac10a..df7ab9373bd0
Created with:
roll-dep third_party/skia
Change-Id: I09efdb69b95070f7d2d2b818c0334f5d9f9666c0
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/134011
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Roll third_party/rust, third_party/skia
Roll third_party/rust/ 483563e40..8bbd6f555 (49 commits)
https://chromium.googlesource.com/chromium/src/third_party/rust/+log/483563e40f9d..8bbd6f5553fd
Created with:
roll-dep third_party/rust
Roll third_party/skia/ eaa402365..9a5e09aac (175 commits; 16 trivial
rolls)
https://skia.googlesource.com/skia.git/+log/eaa402365ff5..9a5e09aac10a
This is a partial roll, since the next commit introduces compiler
errors: https://skia-review.googlesource.com/c/skia/+/1009933.
Created with:
roll-dep third_party/skia
Change-Id: I6f367ba318e8121b600b3e564a4a7eb8ede34e54
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133750
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Roll tools/clang/ a8d02857f..b17ffb3e8 (44 commits)
https://chromium.googlesource.com/chromium/src/tools/clang/+log/a8d02857f16c..b17ffb3e80e6
Roll clang llvmorg-21-init-11777-gfd3fecfc-1 :
llvmorg-21-init-16348-gbd809ffb-12.
Created with:
roll-dep tools/clang
Change-Id: I2d80fcbf5356116ecbe8e6fc0fd62b94397a0ee8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133975
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Roll third_party/libunwind/src/ e3eb847e5..634c60974 (3 commits)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/e3eb847e51789..634c609746c6
Change-Id: I39763c1f2c2fbb04ad37a3cd712bd11f5a800016
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133970
Auto-Submit: Andy Phan <andyphan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Roll v8/ e82d457e6..9bfa30b42 (688 commits)
https://chromium.googlesource.com/v8/v8.git/+log/e82d457e64ee..9bfa30b427e5
Version 14.0.166
Created with:
roll-dep v8
Change-Id: Ic973411b619cb8e8b143187837f5addbfc6fc937
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133990
Auto-Submit: Andy Phan <andyphan@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Update reclient_version to 0.179.0.28341fc7-gomaip
Change-Id: I97e85e3edbaae3fa46b50a196341239ae5192b94
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133972
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Auto-Submit: Andy Phan <andyphan@chromium.org>
Commit-Queue: Andy Phan <andyphan@chromium.org>
Roll third_party/libc++abi/src/ aca866473..4a1b48642 (5 commits)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi.git/+log/aca866473883..4a1b4864252e
Created with:
roll-dep third_party/libc++abi/src
Change-Id: I6b13bc46c8e2fcd00d3cf9306deaa2dd0971c06f
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133950
Auto-Submit: Andy Phan <andyphan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Roll third_party/llvm-libc/src/ 81a117beb..f37e727ed (98 commits)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libc.git/+log/81a117beb4d0..f37e727ed139
Created with:
roll-dep third_party/llvm-libc/src
Change-Id: I7ba4a4edd08e03729dc8a894b5b0677c36834964
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133971
Auto-Submit: Andy Phan <andyphan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Roll libpng from 058e1ebb3139 to cb7e5155c4a1 (1 revision)
https://chromium.googlesource.com/chromium/src/third_party/libpng.git/+log/058e1ebb3139..cb7e5155c4a1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/libpng-pdfium
Please CC andyphan@google.com,thestig@chromium.org on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: andyphan@google.com
Change-Id: Iee84dcbf4a599be2cb99dac3e4cb42ce14d07f71
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133930
Bot-Commit: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Rename resultdb_version DEPS entry to result_adapter_revision
Rename the resultdb_version DEPS entry to result_adapter_revision to
match the corresponding Chromium DEPS entry that was updated in
http://crrev.com/1468556.
Change-Id: If96e73851a4a8e4dd049d26a10c795516c30ee04
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133771
Commit-Queue: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Update gn_version to 97b68a0bb62b7528bc3491c7949d6804223c2b82
Change-Id: I6196043180ec2688be90460ea1917d496f40cd27
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133790
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Andy Phan <andyphan@chromium.org>
Roll third_party/nasm/ 9f916e90e..e2c93c349 (2 commits)
https://chromium.googlesource.com/chromium/deps/nasm.git/+log/9f916e90e6fc..e2c93c34982b
Created with:
roll-dep third_party/nasm
Change-Id: Ib5a6f902695f6f7197f3ed707df2d742bf43f7ac
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133732
Auto-Submit: Andy Phan <andyphan@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Roll third_party/googletest/src/ e9092b12d..c67de1173 (10 commits)
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/e9092b12dc3c..c67de117379f
Created with:
roll-dep third_party/googletest/src
Change-Id: I103161434792eab4e97d9fef20d7f3662db38c50
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133770
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Auto-Submit: Andy Phan <andyphan@chromium.org>
Roll third_party/freetype/src/ 320b72a29..39d85f169 (34 commits)
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/320b72a2955a..39d85f169240
Created with:
roll-dep third_party/freetype/src
Change-Id: Iaeed1dd803efbcc47fac94086078a167752964d5
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133731
Auto-Submit: Andy Phan <andyphan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Roll base/allocator/partition_allocator/ e3668842c..79b418050 (15 commits)
https://chromium.googlesource.com/chromium/src/base/allocator/partition_allocator.git/+log/e3668842ccb3..79b418050876
Created with:
roll-dep base/allocator/partition_allocator
Change-Id: I962bfd812902d66ad63cdfd592ad6987f31688c1
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133711
Auto-Submit: Andy Phan <andyphan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Roll third_party/simdutf/ 9d3e4d7c1..a1046f20f (2 commits)
https://chromium.googlesource.com/chromium/src/third_party/simdutf/+log/9d3e4d7c1afb..a1046f20f709
Created with:
roll-dep third_party/simdutf
Change-Id: Ide5f462862924c08ea49fba66b544c2643ec9038
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133710
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Auto-Submit: Andy Phan <andyphan@chromium.org>
Roll Zlib from a1f2fe223f55 to 4028ebf8710e (2 revisions)
https://chromium.googlesource.com/chromium/src/third_party/zlib.git/+log/a1f2fe223f55..4028ebf8710e
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/zlib-pdfium
Please CC thestig@chromium.org,thestig@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr: thestig@google.com
Change-Id: Ie17cfde1f518040b34c5bc1e4411df2d65f4aefd
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133690
Commit-Queue: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: pdfium-autoroll <pdfium-autoroll@skia-public.iam.gserviceaccount.com>
Do IWYU for free()
Add <stdlib.h> where needed.
Change-Id: I587749ede428eb341c62c3ea3365e628e440da8e
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133670
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Avoid -Wcharacter-conversion
Followup to https://pdfium-review.googlesource.com/c/pdfium/+/133330,
this uses the same strategy to avoid the warning because we're not
actually treating these as characters.
Bug: 417996267
Change-Id: I0eb698726a3390fca34644f86c4f59cc1c9ff10b
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133630
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Use default/projection forms of C++20 std::ranges::lower_bound()
-- same with upper_bound.
Change-Id: I60728a199f498649828c0ca9692dd79512dc3382
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133470
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Fix UNSAFE_TODOs in cpdf_security_handler.cpp
Change-Id: Ic1c624454360842e928f38ec70e3339550520040
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133110
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Fix FPDFText_GetText() handling with invalid characters
Due to the changes in [1], what is now CPDF_TextPage::Init() has a
slightly different notion of what is "normal" compared to
AddCharInfoByLRDirection() and AddCharInfoByRLDirection(). Fix this
discrepancy by adding IsNormalCharacter() and using it from all 3 call
sites. Then update tests to reflect this change.
[1] https://pdfium-review.googlesource.com/27051
Bug: 425244539
Change-Id: Iedcba804ff3a210b5295f27daaee319c8725c159
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133551
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Fix UNSAFE_TODOs in cpdf_crypto_handler.cpp
-- Move context to anonymous namespace.
Change-Id: I99b9ad48b779091301f1e6d4a3015acf5cd567d6
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133090
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Add embedder test for FPDFText_GetText() behavior with invalid chars
Take the relevant part of the PDF from the bug and combine it with
hello_world.pdf into a minimal test case. Demonstrate FPDFText_GetText()
currently cannot return the valid characters, and FPDFText_FindStart()
cannot find them either.
Bug: 425244539
Change-Id: Ic90d64566e45e9c3ea39ca5132b0533f678a5af8
Reviewed-on: https://pdfium-review.googlesource.com/c/pdfium/+/133550
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>