chromium
| Legend: | Passed | Failed | Running | Exception |
Turn HarfBuzz given range `DCHECK` to `CHECK`
When the given range is invalid, such as `end < `start`,
HarfBuzz can cause severe errors including `SECURITY_DCHECK`.
This patch changes `DCHECK` on the entry to `CHECK`. This
makes it easier to distinguish whether errors come from
invalid arguments in the callers or from HarfBuzz itself.
Bug: 433647419
Change-Id: I0afba2ce1e0fc16f6b103d0abe4305f048066618
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782438
Auto-Submit: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491243}
audit_non_blink_usage: Reject WTF:: in new code
* WTF::* was allowed because it was not recognized as an identifier.
This CL updates a regular expression to cover WTF::*, and it is
disallowed by default.
* Update a rule for BindOnce/Repeating.
Bug: 422768753
Change-Id: Idff00ab7791d91b9105e97042e2f0a7b7f0e0a42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780182
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491242}
Replace WTF:: with blink:: in documents
This CL has no behavior changes.
Bug: 422768753
Change-Id: Ie1058bd708fa3cd6bd07d0a9173c6bab5fbbab52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780142
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491241}
Forward the return key to the omniboxKeyboardDelegate
This CL fixes a bug where the copied-link suggestion was not navigated
to when hitting the return key.
Prior to this CL, the return key was not triggering any call to
OmniboxTextFieldIOS nor its delegate. This CL adds the same explicit
handling as for arrow keys.
Fixed: 40836724
Change-Id: I1f444e9e7ec6c14468064102c02a9047b15f4c99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6773725
Reviewed-by: Christian Xu <christianxu@chromium.org>
Auto-Submit: Louis Romero <lpromero@google.com>
Commit-Queue: Louis Romero <lpromero@google.com>
Cr-Commit-Position: refs/heads/main@{#1491240}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1753324191-946ce75bfc0f44d02de1ebab81b2a8335985076f-ed097db5805c04ff8d5593196598d8db0293a825.profdata to chrome-android64-main-1753327782-11ce9f6d91fa4d90ca5289625ce9c6db0e6617b9-cff8173dc17c32f64c910b116c5ef05fb56daddd.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I2f968a4a721906150ca5aee7a9873b65ffebb7a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782502
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491239}
Roll clank/internal/apps from 08f659e4dc8f to 004095b7e48c (1 revision)
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/08f659e4dc8f..004095b7e48c
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll
Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: None
Tbr:
No-Try: true
Change-Id: I51b4e78e05cb844e3dd649816e0753267ca5631e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782504
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491238}
Fix `PDFiumOnDemandSearchifier` current page unloading.
Searchifier crashes in the following scenario:
1. A previously unloaded page is sent to OCR.
2. OCR returns results.
3. The page is scheduled for print and hence the results are not
committed.
4. OCR disconnects.
5. Searchifier tries to unload the page.
To avoid the issue, verify that `current_page_` is not already reset
before trying to unload it.
Bug: 433175512
Change-Id: I354258e4d9acf560f6925a90bd22752b52d85d44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6771407
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491237}
Roll Chrome Mac Arm PGO Profile
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1753314684-7b1d8af4b17e9003032919fefcee7cc879b83668-701ac6259b6182382cbebd32369b58c64a99d12f.profdata to chrome-mac-arm-main-1753322388-1c8ee100d641d8df0e257144a45ced880f5ff181-0b50b83d7110b9015ccd0903bc9a4b1412d4c69b.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-arm-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I2004b5b2ec69e390cd5fa4fbef7ff5aaf87a9620
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782289
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491236}
Roll Arm AFDO from 140.0.7313.0_pre1490386_rc-r1-merged to 140.0.7314.0_pre1490791_rc-r1-merged
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.
Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-arm-chromium
Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: mobiletc-prebuild@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I2b9105ae052851df55f67da486e8d945958e7f0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782568
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491235}
Re-enable held.tentative.https.html WPT
The test is automatically added to expectations by import cl
(https://chromium-review.googlesource.com/c/chromium/src/+/6723156),
but this is not needed. It seems the update on test expected file is
added at the same day, which made the auto bot confused.
(https://chromium-review.googlesource.com/c/chromium/src/+/6713496)
Removing held.tentative.https.html from TestExpectations.
Bug: 431034520
Cq-Include-Trybots: luci.chromium.try:linux-blink-rel
Change-Id: Idfc38634c661cc2f3e1ca6a9f48632c69663eaba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780760
Auto-Submit: Eriko Kurimoto <elkurin@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@chromium.org>
Reviewed-by: Mingyu Lei <leimy@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491234}
[DevTools] Register new badge for DevTools Ai File Assistance
Doc: go/devtools-new-badges
Bug: 427371633
Change-Id: Ib60980d4197950e132f239dbb27468ac7588f826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780580
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491233}
Automated Commit: LKGM 16359.0.0-1070472 for chromeos.
CrOS Changes (16359.0.0-1070466 -> 16359.0.0-1070472):
- External: http://go/cros-changes/78184..78190?ext=true
- Internal: http://go/cros-changes/111872..111878
Uploaded by https://ci.chromium.org/b/8708539091012783393
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-brya-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-jacuzzi-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-reven-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-volteer-chrome
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-octopus-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-jacuzzi-rel
CrOS-LKGM: 16359.0.0-1070472
Merge-Approval-Bypass: Automated LKGM update
Cr-Original-Build-Id: 8708539091012783393
CrOS-External-Manifest-Position: 78190
CrOS-Internal-Manifest-Position: 111878
Change-Id: I1d344f4b9f0c46c83ef8f68f67b8e4ed99572deb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782279
Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491232}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1753321021-f3a0a1a87c86255b70c55837442535504c6fb4b7-53f756a550388a4308378ce3b24df0593abf62d3.profdata to chrome-android64-main-1753324191-946ce75bfc0f44d02de1ebab81b2a8335985076f-ed097db5805c04ff8d5593196598d8db0293a825.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Icb009f1a65dda00e79012d642dc1ee0b1a78e4ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782558
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491231}
Clean up unnecessary image_decoder dependency
This CL removes the chrome/browser/image_decoder dependency from:
- chrome/browser/ui/ash/shelf
- chrome/browser/ash/crosapi
Bug: b:428654878
Change-Id: I7bec450272cae4609c675b96476eff952efcb155
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780425
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Jun Ishiguro <junis@google.com>
Cr-Commit-Position: refs/heads/main@{#1491230}
Roll gn from 85f62c164c82 to 05e031634869
https://gn.googlesource.com/gn.git/+log/85f62c164c82..05e031634869
2025-07-24 thestig@chromium.org Shorten targets from //path/to/foo:foo to //path/to/foo
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/gn-chromium-autoroll
Please CC dpranke@chromium.org,dpranke@google.com,thakis@chromium.org,tikuta@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: dpranke@chromium.org,thakis@chromium.org,tikuta@google.com
Change-Id: Ie75e11f8e712066cd8d30e249ce2ba31d58b5dce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6780697
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491229}
Roll compiler-rt from f11321e08af0 to e2bc292b5860 (2 revisions)
https://chromium.googlesource.com/external/github.com/llvm/llvm-project/compiler-rt.git/+log/f11321e08af0..e2bc292b5860
2025-07-23 bblueconway@gmail.com [ASan][Darwin][GCD] Add interceptor for dispatch_apply (#149238)
2025-07-23 Jake.egan@ibm.com [sanitizer_common][nfc] Rename `tid_t` to avoid conflicting declarations (#149011)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/compiler-rt-chromium
Please CC aeubanks@google.com,lexan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: aeubanks@google.com
Change-Id: I50783568ec8cea0a270af0177c7528fbeabe8e9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782381
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491228}
Remove requirement for context sharing enabled in pinned tabs cause it is broken
Bug: 433154265
Change-Id: I525b779c1ddf56f22ae7541d588d1f7095f1357d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782100
Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491227}
Move wtf/wtf_size_t.h to "blink" namespace
This CL has no behavior changes.
Bug: 422768753
Change-Id: Ied36b5e69eba9af71f721a968b6a9e528f764da3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778748
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491226}
Disable "UseOriginalDomOffsetsForOffsetMap" flag for production
Bug: 430508617
Change-Id: I937cd78228853ffd9f64b125eb07b63af156c5f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6779665
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491225}
Roll Chrome Android ARM64 PGO Profile
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1753316103-aba96dd5a3d6f9357486a4c909c3e2d4a07dacbe-f0b2e763b0287bb864a26296f4645584053d65c8.profdata to chrome-android64-main-1753321021-f3a0a1a87c86255b70c55837442535504c6fb4b7-53f756a550388a4308378ce3b24df0593abf62d3.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-android-arm64-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ieea074c23196b3365bf88767e1bb24446204b818
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782288
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491224}
Roll Chrome Mac PGO Profile
Roll Chrome Mac PGO profile from chrome-mac-main-1753293557-62db5e51f0ed9367feb669a6c23db5eb90b26466-130e6845bbaaef3059f8518d8c550d9f4084401f.profdata to chrome-mac-main-1753314684-f8601a81b6179e9dc0abd448fe34eea60cec9315-701ac6259b6182382cbebd32369b58c64a99d12f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:mac-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: I210696ae84f157dbd2e98d60e655e160c0c28484
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782224
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491223}
Roll Chrome Win32 PGO Profile
Roll Chrome Win32 PGO profile from chrome-win32-main-1753271698-dba84a7f93b583ffd4f2cb2ad6c063c564f9f972-faf031012b7e5c3f8eae3fda40f75490f508e42d.profdata to chrome-win32-main-1753293557-1e5f5de80b7fe2c07413d277b32fb2f829caace6-130e6845bbaaef3059f8518d8c550d9f4084401f.profdata
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win32-chromium
Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Cq-Include-Trybots: luci.chrome.try:win-chrome
Tbr: pgo-profile-sheriffs@google.com
Merge-Approval-Bypass: Chrome autoroller
Change-Id: Ia6827cfd16335b8e5fb907c37b5d5856147d101e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6781815
Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491222}
Refactor: split module templates into separate file.
This will allow in the future for each platform's config to be stored in
a separate, autogenerated file.
Bug: 425527533
Change-Id: I6a6a69646b29f1a4a6238e8b8375b0f88ef5ea07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6778646
Commit-Queue: Matt Stark <msta@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/main@{#1491221}
Roll src-internal from 69aa4b323eee to c304aaac9c9d (3 revisions)
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/69aa4b323eee..c304aaac9c9d
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC chrome-browser-infra-team,suzukikeita@google.com on the revert to ensure that a human
is aware of the problem.
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Bug: chromium:1423117
Tbr: suzukikeita@google.com
Change-Id: Ib53851d600e9d1b7696520fb604eb9b26153bfa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6782287
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1491220}
[FSA] Add implementation for "write" permission mode
- Add `blink::mojom::FileSystemAccessPermissionMode::kWrite` and make
the enum a standalone file to resolve dependency issues.
- Update `mojom::FileSystemAccess*Handle::GetPermissionStatus(bool)`
and `mojom::FileSystemAccess*Handle::RequestPermission(bool)` to take
`FileSystemAccessPermissionMode` instead of `bool writable`.
- Pipe down kWrite to content layer and update
`FileSystemAccessHandleBase::DoRequestPermission()` and
`FileSystemAccessHandleBase::DoGetPermissionStatus()` accordingly.
- The new permission mode is NOT surfaced to any IDL yet. And it should
be no impact to existing FileSystemAccess APIs.
Bug: 40276567
Change-Id: Ic9888cf389a553dd06b6d9127f00a9d0087deae8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6767698
Reviewed-by: Austin Sullivan <asully@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Ming-Ying Chung <mych@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1491219}