这是indexloc提供的服务，不要输入任何密码
RESOLVED FIXED 237029
[WASM-GC] Introduce structs types 
https://bugs.webkit.org/show_bug.cgi?id=237029
Summary [WASM-GC] Introduce structs types
Dmitry
Reported 2022-02-22 03:41:10 PST
[WASM-GC] WIP: introduce structs
Attachments
Patch (92.47 KB, patch)
2022-02-22 03:48 PST, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (286.72 KB, patch)
2022-03-30 09:22 PDT, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (289.22 KB, patch)
2022-03-31 23:57 PDT, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (295.97 KB, patch)
2022-04-03 00:45 PDT, Dmitry 		no flags
DetailsFormatted DiffDiff
Patch (298.11 KB, patch)
2022-04-07 04:11 PDT, Dmitry 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Dmitry
Comment 1 2022-02-22 03:48:16 PST
Created attachment 452850 [details] Patch
EWS Watchlist
Comment 2 2022-02-22 03:49:54 PST
This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at "Source/JavaScriptCore/wasm/wasm.json" and "JSTests/wasm/wasm.json".
Radar WebKit Bug Importer
Comment 3 2022-03-01 03:42:18 PST
<rdar://problem/89611482>
Saam Barati
Comment 4 2022-03-01 10:53:06 PST
Comment on attachment 452850 [details] Patch This approach looks good to me. Not sure if you meant to set r?
Dmitry
Comment 5 2022-03-02 02:37:44 PST
I've set the r?
Keith Miller
Comment 6 2022-03-10 07:53:27 PST
Comment on attachment 452850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452850&action=review r=me, should we rename the Signature class to something else. I worry that we’re somewhat misusing that term from classical its classical meaning. > Source/JavaScriptCore/wasm/WasmLimits.h:47 > +constexpr size_t maxStructFieldCount = 1000000; That’s a huge number, can we handle things that large? Is that the spec limit? > Source/JavaScriptCore/wasm/WasmSectionParser.cpp:61 > + return fail(i, "th struct types are not enabled"); Nit: Maybe “th type failed to parse…”, or does ‘fail’ say what section we are in?
Dmitry
Comment 7 2022-03-30 09:22:19 PDT
Created attachment 456130 [details] Patch
Dmitry
Comment 8 2022-03-30 21:52:29 PDT
Reduced maxStructFieldCount, it is not a spec limit so imho 10000 is enough. Also fixed the error message for section parser.
Dmitry
Comment 9 2022-03-31 23:57:37 PDT
Created attachment 456328 [details] Patch
Dmitry
Comment 10 2022-04-03 00:45:55 PDT
Created attachment 456503 [details] Patch
Dmitry
Comment 11 2022-04-07 04:11:18 PDT
Created attachment 456905 [details] Patch
EWS
Comment 12 2022-04-12 09:05:03 PDT
Committed r292773 (249557@main): <https://commits.webkit.org/249557@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 456905 [details].
Note You need to log in before you can comment on or make changes to this bug.