Debian Bug report logs - #801156
dpkg: sometimes does not pass old version to postinst on upgrade

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dpkg: sometimes does not pass old version to postinst on upgrade

Date: Wed, 07 Oct 2015 01:10:33 +0200

[Message part 1 (text/plain, inline)]

Package: dpkg
Version: 1.18.3
Severity: serious

Hi Guillem,

dpkg does not always properly pass the old version number when
calling "postinst configure" on package upgrades, sometimes there
is either no or an empty argument.

I have two cases where an 'apt-get dist-upgrade' from jessie to
stretch calls 'systemd.postinst configure' differently:
* a minimal jessie chroot (incorrect behavior)
* a minimal jessie chroot + bash-completion (correct behavior)

I noticed this while analyzing some strange piuparts failures in jessie
to stretch upgrades. Unfortunately I neglected it for a long time since
I assumed to have hit a strange bug in some systemd support scripts:

1m41.2s ERROR: FAIL: After purging files have disappeared:
  /etc/dbus-1/system.d/org.freedesktop.machine1.conf.dpkg-remove	 not owned
  /etc/systemd/system/halt.target.wants/	 not owned
  /etc/systemd/system/halt.target.wants/hwclock-save.service -> /lib/systemd/system/hwclock-save.service	 not owned
  /etc/systemd/system/poweroff.target.wants/	 not owned
  /etc/systemd/system/poweroff.target.wants/hwclock-save.service -> /lib/systemd/system/hwclock-save.service	 not owned
  /etc/systemd/system/reboot.target.wants/	 not owned
  /etc/systemd/system/reboot.target.wants/hwclock-save.service -> /lib/systemd/system/hwclock-save.service	 not owned

Digging into this I found the systemd.postinst from stretch performing
cleanup of hwclock-save.service and removal of that obsolete conffile
- but strangely only sometimes:

....
# Cleanup hwclock-save.service, which was shipped in jessie.
if dpkg --compare-versions "$2" lt-nl "219-8"; then
   for t in reboot halt poweroff ; do
       rm -fv /etc/systemd/system/${t}.target.wants/hwclock-save.service
       rmdir --ignore-fail-on-non-empty /etc/systemd/system/${t}.target.wants 2> /dev/null || true
   done
fi
....
#DEBHELPER#

(the #DEBHELPER# part gets several dkpm-maintscript-helper rm_conffile calls)


not here, which is wrong:

....
(Reading database ... 7446 files and directories currently installed.)
  Preparing to unpack .../systemd_226-3_amd64.deb ...
  Unpacking systemd (226-3) over (215-17+deb8u2) ...
  Setting up util-linux (2.27-3) ...
  Setting up systemd (226-3) ...
  Installing new version of config file /etc/dbus-1/system.d/org.freedesktop.login1.conf ...
  Installing new version of config file /etc/dbus-1/system.d/org.freedesktop.systemd1.conf ...
  Installing new version of config file /etc/pam.d/systemd-user ...
  Installing new version of config file /etc/systemd/bootchart.conf ...
  Installing new version of config file /etc/systemd/journald.conf ...
  Installing new version of config file /etc/systemd/logind.conf ...
  Installing new version of config file /etc/systemd/resolved.conf ...
  Installing new version of config file /etc/systemd/system.conf ...
  Installing new version of config file /etc/systemd/timesyncd.conf ...
  Installing new version of config file /etc/systemd/user.conf ...
  Created symlink from /etc/systemd/system/sysinit.target.wants/systemd-timesyncd.service to /lib/systemd/system/systemd-timesyncd.service.
  addgroup: The group `systemd-journal' already exists as a system group. Exiting.
  (Reading database ... 
....

but here, which is correct:

....
(Reading database ... 8034 files and directories currently installed.)
  Preparing to unpack .../systemd_226-3_amd64.deb ...
  Unpacking systemd (226-3) over (215-17+deb8u2) ...
  Setting up util-linux (2.27-3) ...
  Setting up systemd (226-3) ...
  Installing new version of config file /etc/dbus-1/system.d/org.freedesktop.login1.conf ...
  Installing new version of config file /etc/dbus-1/system.d/org.freedesktop.systemd1.conf ...
  Installing new version of config file /etc/pam.d/systemd-user ...
  Installing new version of config file /etc/systemd/bootchart.conf ...
  Installing new version of config file /etc/systemd/journald.conf ...
  Installing new version of config file /etc/systemd/logind.conf ...
  Installing new version of config file /etc/systemd/resolved.conf ...
  Installing new version of config file /etc/systemd/system.conf ...
  Installing new version of config file /etc/systemd/timesyncd.conf ...
  Installing new version of config file /etc/systemd/user.conf ...
  Created symlink from /etc/systemd/system/sysinit.target.wants/systemd-timesyncd.service to /lib/systemd/system/systemd-timesyncd.service.
  addgroup: The group `systemd-journal' already exists as a system group. Exiting.
  Removing obsolete conffile /etc/dbus-1/system.d/org.freedesktop.machine1.conf ...
  (Reading database ... 
....


So I rebuilt systemd with more debug output in the postinst script to see the following:

....
  (Reading database ... 7446 files and directories currently installed.)
  Preparing to unpack ..././systemd_226-4.1_amd64.deb ...
  Unpacking systemd (226-4.1) over (215-17+deb8u2) ...
  Setting up util-linux (2.27-3) ...
  Setting up systemd (226-4.1) ...
  Installing new version of config file /etc/dbus-1/system.d/org.freedesktop.login1.conf ...
  Installing new version of config file /etc/dbus-1/system.d/org.freedesktop.systemd1.conf ...
  Installing new version of config file /etc/pam.d/systemd-user ...
  Installing new version of config file /etc/systemd/bootchart.conf ...
  Installing new version of config file /etc/systemd/journald.conf ...
  Installing new version of config file /etc/systemd/logind.conf ...
  Installing new version of config file /etc/systemd/resolved.conf ...
  Installing new version of config file /etc/systemd/system.conf ...
  Installing new version of config file /etc/systemd/timesyncd.conf ...
  Installing new version of config file /etc/systemd/user.conf ...
  + echo ** this is /var/lib/dpkg/info/systemd.postinst configure 
  ** this is /var/lib/dpkg/info/systemd.postinst configure 
  + set -e
  + [ configure = triggered ]
  + dpkg --compare-versions  lt 214-1
  + systemctl enable getty@tty1.service
  + systemctl enable remote-fs.target
  + dpkg --compare-versions  lt 218-11~
  + systemctl enable systemd-timesyncd.service
  Created symlink from /etc/systemd/system/sysinit.target.wants/systemd-timesyncd.service to /lib/systemd/system/systemd-timesyncd.service.
  + dpkg --compare-versions  lt 33-1
  + [ -f /etc/default/rcS ]
  + . /etc/default/rcS
....
  + dpkg --compare-versions  ge 204
  + [ -n  ]
  + dpkg --compare-versions  lt-nl 219-8
  + echo NO hwclock-save.service cleanup ()
  NO hwclock-save.service cleanup ()
  + _systemctl is-active --quiet resolvconf
  + [ -d /run/systemd/system ]
  + _systemctl start systemd-networkd-resolvconf-update.path
  + [ -d /run/systemd/system ]
  + [ -d /run/systemd/system ]
  + dpkg-maintscript-helper rm_conffile /etc/bash_completion.d/systemctl-bash-completion.sh 204-1~ systemd -- configure 
  + dpkg-maintscript-helper rm_conffile /etc/bash_completion.d/systemd-bash-completion.sh 204-1~ systemd -- configure 
  + dpkg-maintscript-helper mv_conffile /etc/systemd/systemd-logind.conf /etc/systemd/logind.conf 204-1~ systemd -- configure 
  + dpkg-maintscript-helper mv_conffile /etc/systemd/systemd-journald.conf /etc/systemd/journald.conf 204-1~ systemd -- configure 
  + dpkg-maintscript-helper rm_conffile /etc/dbus-1/system.d/org.freedesktop.machine1.conf 224-2~ systemd -- configure 
  (Reading database ... 
....

So the postinst script is called without a "$2" parameter of "215-17+deb8u2"
causing several postinst actions to be skipped. It may be that there is an
empty string being passed instead, since 'echo "** this is $0 $@"' emitted
a trailing space:
"** this is /var/lib/dpkg/info/systemd.postinst configure "


And this is the output in the case where it is correct:


....
(Reading database ... 8034 files and directories currently installed.)
  Preparing to unpack ..././systemd_226-4.1_amd64.deb ...
  Unpacking systemd (226-4.1) over (215-17+deb8u2) ...
  Setting up util-linux (2.27-3) ...
  Setting up systemd (226-4.1) ...
  Installing new version of config file /etc/dbus-1/system.d/org.freedesktop.login1.conf ...
  Installing new version of config file /etc/dbus-1/system.d/org.freedesktop.systemd1.conf ...
  Installing new version of config file /etc/pam.d/systemd-user ...
  Installing new version of config file /etc/systemd/bootchart.conf ...
  Installing new version of config file /etc/systemd/journald.conf ...
  Installing new version of config file /etc/systemd/logind.conf ...
  Installing new version of config file /etc/systemd/resolved.conf ...
  Installing new version of config file /etc/systemd/system.conf ...
  Installing new version of config file /etc/systemd/timesyncd.conf ...
  Installing new version of config file /etc/systemd/user.conf ...
  + echo ** this is /var/lib/dpkg/info/systemd.postinst configure 215-17+deb8u2
  ** this is /var/lib/dpkg/info/systemd.postinst configure 215-17+deb8u2
  + set -e
  + [ configure = triggered ]
  + dpkg --compare-versions 215-17+deb8u2 lt 214-1
  + dpkg --compare-versions 215-17+deb8u2 lt 218-11~
  + systemctl enable systemd-timesyncd.service
  Created symlink from /etc/systemd/system/sysinit.target.wants/systemd-timesyncd.service to /lib/systemd/system/systemd-timesyncd.service.
  + dpkg --compare-versions 215-17+deb8u2 lt 33-1
....
  + [ -n 215-17+deb8u2 ]
  + _systemctl daemon-reexec
  + [ -d /run/systemd/system ]
  + _systemctl try-restart systemd-networkd.service
  + [ -d /run/systemd/system ]
  + _systemctl try-restart systemd-resolved.service
  + [ -d /run/systemd/system ]
  + _systemctl try-restart systemd-timesyncd.service
  + [ -d /run/systemd/system ]
  + dpkg --compare-versions 215-17+deb8u2 lt-nl 219-8
  + echo cleanup hwclock-save.service
  cleanup hwclock-save.service
  + rm -fv /etc/systemd/system/reboot.target.wants/hwclock-save.service
  removed '/etc/systemd/system/reboot.target.wants/hwclock-save.service'
  + rmdir --ignore-fail-on-non-empty /etc/systemd/system/reboot.target.wants
  + rm -fv /etc/systemd/system/halt.target.wants/hwclock-save.service
  removed '/etc/systemd/system/halt.target.wants/hwclock-save.service'
  + rmdir --ignore-fail-on-non-empty /etc/systemd/system/halt.target.wants
  + rm -fv /etc/systemd/system/poweroff.target.wants/hwclock-save.service
  removed '/etc/systemd/system/poweroff.target.wants/hwclock-save.service'
  + rmdir --ignore-fail-on-non-empty /etc/systemd/system/poweroff.target.wants
  + _systemctl is-active --quiet resolvconf
  + [ -d /run/systemd/system ]
  + _systemctl start systemd-networkd-resolvconf-update.path
  + [ -d /run/systemd/system ]
  + [ -d /run/systemd/system ]
  + dpkg-maintscript-helper rm_conffile /etc/bash_completion.d/systemctl-bash-completion.sh 204-1~ systemd -- configure 215-17+deb8u2
  + dpkg-maintscript-helper rm_conffile /etc/bash_completion.d/systemd-bash-completion.sh 204-1~ systemd -- configure 215-17+deb8u2
  + dpkg-maintscript-helper mv_conffile /etc/systemd/systemd-logind.conf /etc/systemd/logind.conf 204-1~ systemd -- configure 215-17+deb8u2
  + dpkg-maintscript-helper mv_conffile /etc/systemd/systemd-journald.conf /etc/systemd/journald.conf 204-1~ systemd -- configure 215-17+deb8u2
  + dpkg-maintscript-helper rm_conffile /etc/dbus-1/system.d/org.freedesktop.machine1.conf 224-2~ systemd -- configure 215-17+deb8u2
  Removing obsolete conffile /etc/dbus-1/system.d/org.freedesktop.machine1.conf ...
(Reading database ... 


So in these two cases completely different codepaths in the postinst are taken.
I don't know about other packages, since this is (so far) the only one leaving
a visible trace from this mistreatment in piuparts. (Well, there are several
other systemd symlink related problems that nobody managed to debug so far.)


Attached are two logs where I did this upgrade test with piuparts, but
it should be quite easy to reproduce it manually.


Andreas

[bad.log.gz (application/gzip, attachment)]

[good.log.gz (application/gzip, attachment)]

Message #10 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: Andreas Beckmann <anbe@debian.org>, 801156@bugs.debian.org

Subject: Re: Bug#801156: dpkg: sometimes does not pass old version to postinst on upgrade

Date: Wed, 7 Oct 2015 02:23:58 +0200

Hi!

On Wed, 2015-10-07 at 01:10:33 +0200, Andreas Beckmann wrote:
> Package: dpkg
> Version: 1.18.3
> Severity: serious

> dpkg does not always properly pass the old version number when
> calling "postinst configure" on package upgrades, sometimes there
> is either no or an empty argument.

That's to be expected, the second argument is the last version that
got configured, if no version has ever been configured then the
argument is omitted. Checking now, this is documented in Debian
policy §6.7.

> I have two cases where an 'apt-get dist-upgrade' from jessie to
> stretch calls 'systemd.postinst configure' differently:
> * a minimal jessie chroot (incorrect behavior)
> * a minimal jessie chroot + bash-completion (correct behavior)

> So in these two cases completely different codepaths in the postinst are taken.
> I don't know about other packages, since this is (so far) the only one leaving
> a visible trace from this mistreatment in piuparts. (Well, there are several
> other systemd symlink related problems that nobody managed to debug so far.)

> Attached are two logs where I did this upgrade test with piuparts, but
> it should be quite easy to reproduce it manually.

I've not checked the logs, but I'd assume that in the problematic case
the package has never been configured before, and as such the bug here
is on that specific package.

Thanks,
Guillem

Message #15 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: Guillem Jover <guillem@debian.org>, 801156@bugs.debian.org

Subject: Re: Bug#801156: dpkg: sometimes does not pass old version to postinst on upgrade

Date: Wed, 07 Oct 2015 03:18:26 +0200

On 2015-10-07 02:23, Guillem Jover wrote:
> Hi!
> 
> On Wed, 2015-10-07 at 01:10:33 +0200, Andreas Beckmann wrote:
>> Package: dpkg
>> Version: 1.18.3
>> Severity: serious
> 
>> dpkg does not always properly pass the old version number when
>> calling "postinst configure" on package upgrades, sometimes there
>> is either no or an empty argument.
> 
> That's to be expected, the second argument is the last version that
> got configured, if no version has ever been configured then the
> argument is omitted. Checking now, this is documented in Debian
> policy §6.7.

> I've not checked the logs, but I'd assume that in the problematic case
> the package has never been configured before, and as such the bug here
> is on that specific package.

That is unlikely. Both tests start from the same chroot tarball
(debootstrapped about a month ago)

Right before packing it up the status was listed as

  ii  systemd   215-17+deb8u2    amd64    system and service manager

so I assume it has been configured during the debootstrap run.

If I enter that chroot with pbuilder login, the status of the systemd
package is listed as

Package: systemd
Status: install ok installed
Priority: important
Section: admin
Installed-Size: 13838
Maintainer: Debian systemd Maintainers
<pkg-systemd-maintainers@lists.alioth.debian.org>
Architecture: amd64
Version: 215-17+deb8u2
Depends: libacl1 (>= 2.2.51-8), libaudit1 (>= 1:2.2.1), libblkid1 (>=
2.19.1), libcap2 (>= 1:2.10), libcryptsetup4 (>= 2:1.4.3), libkmod2 (>=
5~), libpam0g (>= 0.99.7.1), libselinux1 (>= 2.1.9), libsystemd0 (=
215-17+deb8u2), util-linux (>= 2.19.1-2), mount (>= 2.21), initscripts
(>= 2.88dsf-53.2), sysv-rc, udev (>= 208-8), acl, adduser, libcap2-bin
Pre-Depends: libc6 (>= 2.17), libgcrypt20 (>= 1.6.1), liblzma5 (>=
5.1.1alpha+20120614), libselinux1 (>= 1.32)
Recommends: libpam-systemd, dbus
Suggests: systemd-ui
Breaks: lsb-base (<< 4.1+Debian4), lvm2 (<< 2.02.104-1), systemd-shim
(<< 8-2)
Conflicts: klogd
Conffiles:
 /etc/dbus-1/system.d/org.freedesktop.hostname1.conf
f55c94d000b5d62b5f06d38852977dd1
 /etc/dbus-1/system.d/org.freedesktop.locale1.conf
5893ab03e7e96aa3759baceb4dd04190
 /etc/dbus-1/system.d/org.freedesktop.login1.conf
96bf488f3da8f0ca813cc78e71eeb605
 /etc/dbus-1/system.d/org.freedesktop.machine1.conf
d658acaf7192de735ab798c58ab149ae
 /etc/dbus-1/system.d/org.freedesktop.systemd1.conf
46533268285a0df22b1f1667ddc05642
 /etc/dbus-1/system.d/org.freedesktop.timedate1.conf
682369fbf3de26b21e775732c89a2bbe
 /etc/pam.d/systemd-user aebb8b8a2c698614b00961f327a683ef
 /etc/systemd/bootchart.conf 838a83315ad2f9d4c4b7f20b7475ba28
 /etc/systemd/journald.conf 51f19202dcc5aff6d2c3448dbf92f354
 /etc/systemd/logind.conf 747ae2312b6922546190bf806d8d12be
 /etc/systemd/resolved.conf 81a9c57d4eb587decc49040595674c5a
 /etc/systemd/system.conf 3d0e13a72d72acb55409a831b72a15e6
 /etc/systemd/timesyncd.conf 605e4f25097b8ea22f2f5cb3fde3f13c
 /etc/systemd/user.conf 9eaad8fbb7bb6230d4b28abb76b4e81c
Description: system and service manager
 systemd is a replacement for sysvinit.  It is dependency-based and


>> I have two cases where an 'apt-get dist-upgrade' from jessie to
>> stretch calls 'systemd.postinst configure' differently:
>> * a minimal jessie chroot (incorrect behavior)
>> * a minimal jessie chroot + bash-completion (correct behavior)

and starting from that chroot.tgz I can reproduce the two upgrade paths
with the differing behavior manually:

  apt-get install bash-completion  # only for the "correct" one
  sed -i s/jessie/stretch/ /etc/apt/sources.list
  apt-get update
  apt-get dist-upgrade


If the postinst is invoked correctly the configuration of systemd ends
with the removal of an obsolete conffile:

...
Unpacking systemd (226-3) over (215-17+deb8u2) ...
Setting up util-linux (2.27-3) ...
Setting up systemd (226-3) ...
...
Removing obsolete conffile
/etc/dbus-1/system.d/org.freedesktop.machine1.conf ...
...

If the postinst is incorrectly invoked like it were an initial install,
the obsolete conffile removal is missing.


if I start with

  apt-get install bash-completion
  apt-get purge bash-completion

I also get into the incorrect behavior.



You can find the chroot at people.debian.org: ~anbe/jessie_amd64.tar.gz
You may have to nuke the proxy setting in /etc/apt/apt.conf.d/piuparts
to test this yourself.



Andreas

Message #20 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: Guillem Jover <guillem@debian.org>, 801156@bugs.debian.org

Subject: Re: Bug#801156: dpkg: sometimes does not pass old version to postinst on upgrade

Date: Wed, 07 Oct 2015 03:29:10 +0200

The chroot was bootstrapped with

'debootstrap' '--variant=minbase' '--keyring=/usr/share/keyrings/debian-archive-keyring.gpg' '--components=main' '--arch=amd64' 'jessie' '/tmp/piupartss/tmpcNOJI3' 'http://ftp.de.debian.org/debian'

and was slightly configured by piuparts to have e.g.

# cat /etc/apt/apt.conf.d/piuparts 
APT::Get::Assume-Yes "yes";
APT::Install-Recommends "0";
APT::Install-Suggests "0";
APT::Get::AllowUnauthenticated "No";
Acquire::PDiffs "false";
Acquire::http::Proxy "http://localhost:3128";
Dpkg::Options {"--force-unsafe-io";};


Andreas

Message #25 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: Andreas Beckmann <anbe@debian.org>, 801156@bugs.debian.org

Subject: Re: Bug#801156: dpkg: sometimes does not pass old version to postinst on upgrade

Date: Sat, 10 Oct 2015 16:13:11 +0200

[Message part 1 (text/plain, inline)]

Hi!

On Wed, 2015-10-07 at 03:29:10 +0200, Andreas Beckmann wrote:
> The chroot was bootstrapped with
> 
> 'debootstrap' '--variant=minbase' '--keyring=/usr/share/keyrings/debian-archive-keyring.gpg' '--components=main' '--arch=amd64' 'jessie' '/tmp/piupartss/tmpcNOJI3' 'http://ftp.de.debian.org/debian'
> 
> and was slightly configured by piuparts to have e.g.
> 
> # cat /etc/apt/apt.conf.d/piuparts 
> APT::Get::Assume-Yes "yes";
> APT::Install-Recommends "0";
> APT::Install-Suggests "0";
> APT::Get::AllowUnauthenticated "No";
> Acquire::PDiffs "false";
> Acquire::http::Proxy "http://localhost:3128";
> Dpkg::Options {"--force-unsafe-io";};

Thanks for the recipe. I was going through the code to see why this
might be happening and realized that it is most probably caused by
systemd being in triggers-pending state, which the code was not taking
into account. I've prepared a patch, but I've not yet setup the test
environment, if you have it ready, could you try to test a dpkg with
this patch to see if it fixed it for you?

I think I might instead create a reduced test case for the dpkg-tests
functional test suite, which should be faster to reproduce and retest.

Thanks,
Guillem

[0001-libdpkg-Config-Version-should-also-be-initialized-on.patch (text/x-diff, attachment)]

Message #30 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: Andreas Beckmann <anbe@debian.org>, 801156@bugs.debian.org

Subject: Re: Bug#801156: dpkg: sometimes does not pass old version to postinst on upgrade

Date: Sun, 11 Oct 2015 17:10:34 +0200

Hi!

On Sat, 2015-10-10 at 16:13:11 +0200, Guillem Jover wrote:
> Thanks for the recipe. I was going through the code to see why this
> might be happening and realized that it is most probably caused by
> systemd being in triggers-pending state, which the code was not taking
> into account. I've prepared a patch, but I've not yet setup the test
> environment, if you have it ready, could you try to test a dpkg with
> this patch to see if it fixed it for you?

> I think I might instead create a reduced test case for the dpkg-tests
> functional test suite, which should be faster to reproduce and retest.

I've done this now, and I can reproduce it, and the previously attached
patch fixes the issue. I'll push the fix later today, and queue it for
all the supported stable releases. The test case is:

  <http://anonscm.debian.org/cgit/dpkg/dpkg-tests.git/commit/?id=893514e4bb60bca7e8078932db932afa52af5bb6>

Knowing that it also fixes the issues in piuparts would be valuable I
guess, but I'd be very happy if someone else could check that out. :)

Thanks,
Guillem

Message #35 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Andreas Beckmann <anbe@debian.org>

To: 801156@bugs.debian.org

Subject: Re: Bug#801156: dpkg: sometimes does not pass old version to postinst on upgrade

Date: Tue, 13 Oct 2015 21:31:32 +0200

On 2015-10-10 16:13, Guillem Jover wrote:
> Thanks for the recipe. I was going through the code to see why this
> might be happening and realized that it is most probably caused by
> systemd being in triggers-pending state, which the code was not taking
> into account. I've prepared a patch, but I've not yet setup the test
> environment, if you have it ready, could you try to test a dpkg with
> this patch to see if it fixed it for you?

Yes, this seems to fix the issue.

(I didn't manage to build dpkg from git with git-buildpackage and
pbuilder, so I ended up patching the 1.18.3 tarball and pbuilding that)


Andreas

Message #38 received at 801156-submitter@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: 801156-submitter@bugs.debian.org

Subject: Bug#801156 marked as pending

Date: Sun, 18 Oct 2015 03:40:50 +0000

Control: tag 801156 pending

Hi!

Bug #801156 reported by you has been fixed in the Git repository. You can
see the changelog below, and you can check the diff of the fix at:

    https://anonscm.debian.org/cgit/dpkg/dpkg.git/diff/?id=10d77ba

---
commit 10d77ba878eb998b3eede0c5ac7917a901de05b0
Author: Guillem Jover <guillem@debian.org>
Date:   Sat Oct 10 16:06:41 2015 +0200

    libdpkg: Config-Version should also be initialized on triggers-pending
    
    A package in triggers-pending state should be considered an installed
    package, by not doing so we might end up not passing the correct version
    to the configure maintainer script and making it look like we are doing
    a configuration for a first install, instead of an upgrade.
    
    Closes: #801156
    Reported-by: Andreas Beckmann <anbe@debian.org>
    Stable-Candidate: 1.16.x 1.17.x

diff --git a/debian/changelog b/debian/changelog
index 6c27993..82f811a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,10 @@ dpkg (1.18.4) UNRELEASED; urgency=low
   * Switch dpkg-scansources and dpkg-scanpackages to use File::Find instead
     of find(1), as the former is more portable with more consistent behavior,
     and always canonicalizes the pathnames. Closes: #800649
+  * Initialize Config-Version also for packages previously in triggers-pending
+    state, otherwise we end up not passing the previously configured version
+    to «postinst configure», which might consider this a first install instead
+    of an upgrade. Closes: #801156
   * Build system:
     - Set PERL5LIB globally for the test suite to the local modules directory,
       to avoid using the system modules. Regression introduced in dpkg 1.17.8.

Message #47 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: 801156@bugs.debian.org, Guillem Jover <guillem@debian.org>

Cc: Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>

Subject: Re: Bug#801156 marked as pending

Date: Wed, 25 Nov 2015 00:59:25 +0100

[Message part 1 (text/plain, inline)]

Hi Guillem!

On Sun, 18 Oct 2015 03:40:50 +0000 Guillem Jover <guillem@debian.org> wrote:
> Control: tag 801156 pending
> 
> Hi!
> 
> Bug #801156 reported by you has been fixed in the Git repository. You can
> see the changelog below, and you can check the diff of the fix at:
> 
>     https://anonscm.debian.org/cgit/dpkg/dpkg.git/diff/?id=10d77ba
> 
> ---
> commit 10d77ba878eb998b3eede0c5ac7917a901de05b0
> Author: Guillem Jover <guillem@debian.org>
> Date:   Sat Oct 10 16:06:41 2015 +0200
> 
>     libdpkg: Config-Version should also be initialized on triggers-pending
>     
>     A package in triggers-pending state should be considered an installed
>     package, by not doing so we might end up not passing the correct version
>     to the configure maintainer script and making it look like we are doing
>     a configuration for a first install, instead of an upgrade.
>     
>     Closes: #801156
>     Reported-by: Andreas Beckmann <anbe@debian.org>
>     Stable-Candidate: 1.16.x 1.17.x
> 


I just encountered another instance of this issue.
While preparing an upload for systemd, I tested the change for
https://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=34165f8d3429ff419bf45234b1a92e127468145f

But unfortunately the conffile is not properly removed. All I get is a
renamed file /etc/X11/xinit/xinitrc.d/50-systemd-user.sh.dpkg-remove
I'm pretty sure this is due to this bug in dpkg.

So, do you plan an upload of dpkg with a fix for this (soonish)?

Regards,
Michael

[signature.asc (application/pgp-signature, attachment)]

Message #52 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: Michael Biebl <biebl@debian.org>

Cc: 801156@bugs.debian.org, Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>

Subject: Re: Bug#801156 marked as pending

Date: Thu, 26 Nov 2015 04:54:50 +0100

Hi!

On Wed, 2015-11-25 at 00:59:25 +0100, Michael Biebl wrote:
> I just encountered another instance of this issue.
> While preparing an upload for systemd, I tested the change for
> https://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=34165f8d3429ff419bf45234b1a92e127468145f

> But unfortunately the conffile is not properly removed. All I get is a
> renamed file /etc/X11/xinit/xinitrc.d/50-systemd-user.sh.dpkg-remove
> I'm pretty sure this is due to this bug in dpkg.
> 
> So, do you plan an upload of dpkg with a fix for this (soonish)?

Yeah, I'm planning an upload during this week.

Thanks,
Guillem

Message #57 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: Michael Biebl <biebl@debian.org>, 801156@bugs.debian.org, Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>

Subject: Re: Bug#801156: marked as pending

Date: Fri, 4 Dec 2015 03:25:55 +0100

Hi!

On Thu, 2015-11-26 at 04:54:50 +0100, Guillem Jover wrote:
> On Wed, 2015-11-25 at 00:59:25 +0100, Michael Biebl wrote:
> > I just encountered another instance of this issue.
> > While preparing an upload for systemd, I tested the change for
> > https://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=34165f8d3429ff419bf45234b1a92e127468145f
> 
> > But unfortunately the conffile is not properly removed. All I get is a
> > renamed file /etc/X11/xinit/xinitrc.d/50-systemd-user.sh.dpkg-remove
> > I'm pretty sure this is due to this bug in dpkg.
> > 
> > So, do you plan an upload of dpkg with a fix for this (soonish)?
> 
> Yeah, I'm planning an upload during this week.

Sorry, I've been swamped with work, and other stuff and I've been
unable to find the time to do this, I hope to be able to sit down
during this weekend. :/

Thanks,
Guillem

Message #62 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Michael Biebl <biebl@debian.org>

To: Guillem Jover <guillem@debian.org>, 801156@bugs.debian.org, Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>

Subject: Re: Bug#801156: marked as pending

Date: Sat, 19 Dec 2015 01:39:36 +0100

[Message part 1 (text/plain, inline)]

Hi Guillem,


Am 04.12.2015 um 03:25 schrieb Guillem Jover:
> Hi!
> 
> On Thu, 2015-11-26 at 04:54:50 +0100, Guillem Jover wrote:
>> On Wed, 2015-11-25 at 00:59:25 +0100, Michael Biebl wrote:
>>> I just encountered another instance of this issue.
>>> While preparing an upload for systemd, I tested the change for
>>> https://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=34165f8d3429ff419bf45234b1a92e127468145f
>>
>>> But unfortunately the conffile is not properly removed. All I get is a
>>> renamed file /etc/X11/xinit/xinitrc.d/50-systemd-user.sh.dpkg-remove
>>> I'm pretty sure this is due to this bug in dpkg.
>>>
>>> So, do you plan an upload of dpkg with a fix for this (soonish)?
>>
>> Yeah, I'm planning an upload during this week.
> 
> Sorry, I've been swamped with work, and other stuff and I've been
> unable to find the time to do this, I hope to be able to sit down
> during this weekend. :/

Sorry for being a pita: are there any news regarding a new upload of dpkg?


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

[signature.asc (application/pgp-signature, attachment)]

Message #69 received at 801156@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: Michael Biebl <biebl@debian.org>, 801156@bugs.debian.org

Cc: Debian systemd Maintainers <pkg-systemd-maintainers@lists.alioth.debian.org>

Subject: Re: Bug#801156: marked as pending

Date: Tue, 22 Dec 2015 02:12:27 +0100

Hi!

On Sat, 2015-12-19 at 01:39:36 +0100, Michael Biebl wrote:
> Am 04.12.2015 um 03:25 schrieb Guillem Jover:
> > On Thu, 2015-11-26 at 04:54:50 +0100, Guillem Jover wrote:
> >> On Wed, 2015-11-25 at 00:59:25 +0100, Michael Biebl wrote:
> >>> I just encountered another instance of this issue.
> >>> While preparing an upload for systemd, I tested the change for
> >>> https://anonscm.debian.org/cgit/pkg-systemd/systemd.git/commit/?id=34165f8d3429ff419bf45234b1a92e127468145f
> >>
> >>> But unfortunately the conffile is not properly removed. All I get is a
> >>> renamed file /etc/X11/xinit/xinitrc.d/50-systemd-user.sh.dpkg-remove
> >>> I'm pretty sure this is due to this bug in dpkg.
> >>>
> >>> So, do you plan an upload of dpkg with a fix for this (soonish)?
> >>
> >> Yeah, I'm planning an upload during this week.
> > 
> > Sorry, I've been swamped with work, and other stuff and I've been
> > unable to find the time to do this, I hope to be able to sit down
> > during this weekend. :/
> 
> Sorry for being a pita: are there any news regarding a new upload of dpkg?

Sorry for being so late on this. :/ This weekend I started rolling the
ball on a new release, I'm now going through pending bug reports, and
will try to have something ready by tomorrow or wednesday at most.

Regards,
Guillem

Message #74 received at 801156-close@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: 801156-close@bugs.debian.org

Subject: Bug#801156: fixed in dpkg 1.18.4

Date: Fri, 25 Dec 2015 13:34:00 +0000

Source: dpkg
Source-Version: 1.18.4

We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 801156@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillem Jover <guillem@debian.org> (supplier of updated dpkg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Fri, 25 Dec 2015 13:20:26 +0100
Source: dpkg
Binary: libdpkg-dev dpkg dpkg-dev libdpkg-perl dselect
Architecture: source
Version: 1.18.4
Distribution: unstable
Urgency: medium
Maintainer: Dpkg Developers <debian-dpkg@lists.debian.org>
Changed-By: Guillem Jover <guillem@debian.org>
Description:
 dpkg       - Debian package management system
 dpkg-dev   - Debian package development tools
 dselect    - Debian package management front-end
 libdpkg-dev - Debian package management static library
 libdpkg-perl - Dpkg perl modules
Closes: 760248 799046 799432 799875 800513 800649 801156 801329 801958 805872 806315 807156 808912
Changes:
 dpkg (1.18.4) unstable; urgency=medium
 .
   [ Guillem Jover ]
   * Switch dpkg-scansources and dpkg-scanpackages to use File::Find instead
     of find(1), as the former is more portable with more consistent behavior,
     and always canonicalizes the pathnames. Closes: #800649
   * Initialize Config-Version also for packages previously in triggers-pending
     state, otherwise we end up not passing the previously configured version
     to «postinst configure», which might consider this a first install instead
     of an upgrade. Closes: #801156
   * Fix memory leaks in «dpkg --verify» and dpkg infodb format upgrade logic.
   * Merge all update-alternatives action handling into a single if-else-if
     block, to unify the code an allow a future switch into a shared library.
   * Perform any necessary cleanups on normal exit from dpkg-divert --add and
     --remove commands.
   * Make dpkg-architecture warning on non-matching GNU system type compiler
     agnostic.
   * Add ‘.gitreview’ to the default dpkg-source ignore lists.
   * Add support for DPKG_MAINTSCRIPT_DEBUG environment variable to dpkg.
   * Fix dpkg-checkbuilddeps exit code to be 1 instead of a random error value
     on unsatisfied dependencies. Regression introduced in dpkg 1.18.3.
   * Fix an off-by-one write access in dpkg-deb when parsing the old format
     .deb control member size. Thanks to Hanno Böck <hanno@hboeck.de>.
     Fixes CVE-2015-0860.
   * Fix an off-by-one read access in dpkg-deb when parsing ar member names.
     Thanks to Hanno Böck <hanno@hboeck.de>.
   * Add experimental multithreaded xz compression support in libdpkg, which
     requires xz >= 5.2.0.
   * Fix physical file offset comparison in dpkg. Closes: #808912
     Thanks to Yuri Gribov <tetra2005@gmail.com>.
   * Fix usage of dpkg-architecture -s after other action options.
     Reported by Niels Thykier <niels@thykier.net>.
   * Add NIOS2 support to cputable. Thanks to Marek Vasut <marex@denx.de>.
   * On Debian and derivatives enable timeless build flag feature by default.
     Thanks to Paul Wise <pabs@debian.org>. Closes: #805872
   * Perl modules:
     - Add support for Build-Essential field. Closes: #806315
   * Test suite:
     - Improve perl code test coverage.
   * Build system:
     - Set PERL5LIB globally for the test suite to the local modules directory,
       to avoid using the system modules. Regression introduced in dpkg 1.17.8.
       Reported by Jérémy Bobbio <lunar@debian.org>. Closes: #801329
     - Use absolute buildir pathnames in PATH variable for the test suite.
     - Descend into scripts directory when cleaning up code coverage files.
     - Add new configure option --disable-devel-docs to select the kind of docs
       to generate, default for now is development documentation.
     - Try to use AM_GNU_GETTEXT_REQUIRE_VERSION to benefit from the latest
       installed gettext version, while guaranteeing a minimal required version.
   * Packaging:
     - Add missing Build-Depends for restriction formula support.
   * Documentation:
     - Move description for “target architecture” from the dpkg-architecture(1)
       ‘-A’ option to the TERMS section. Closes: #799046
     - Clarify that the md5sum check on «dpkg --verify» is performed on the
       file contents, and failures denote changed content. Closes: #760248
     - Document that dpkg-buildpacakge -nc -S implies -d.
     - Clarify role of Build-Depends in deb-src-control(5).
       Prompted by Johannes Schauer <j.schauer@email.de>.
     - Document supported feature areas.
     - Clarify in dpkg-query(1) when binary:Package gets arch-qualified.
       Closes: #801958
     - Add a subsection separating external from internal environment variables
       in dpkg(1).
 .
   [ Updated programs translations ]
   * Dutch (Frans Spiesschaert). Closes: #800513
   * Japanese (Kenshi Muto). Closes: #799432
   * Turkish (Mert Dirik). Closes: #799875
 .
   [ Updated scripts translations ]
   * German (Helge Kreutzmann).
 .
   [ Updated manpages translations ]
   * German (Helge Kreutzmann, Julian R). Closes: #807156
Checksums-Sha1:
 4f1df693463e7279d4d0362dbb00b6116353a933 2053 dpkg_1.18.4.dsc
 87707de6726d27f2c60fbd95bfaf90f888e2afe8 4377024 dpkg_1.18.4.tar.xz
Checksums-Sha256:
 bcf295adfb7d467220586789f3e7b2de78ded2ea035c9c0ba4e97283d39eeb6f 2053 dpkg_1.18.4.dsc
 fe89243868888ce715bf45861f26264f767d4e4dbd0d6f1a26ce60bbbbf106da 4377024 dpkg_1.18.4.tar.xz
Files:
 32a406117e41c649a0df42289d2a8860 2053 admin required dpkg_1.18.4.dsc
 e95b513c89693f6ec3ab53b6b1c3defd 4377024 admin required dpkg_1.18.4.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJWfUNzAAoJELlyvz6krlejO5YP/iDDalDQ7TIRBiR9MysEkzcx
M6p9FZ0eSZY0a3sL9UZ8rYJXPmGuZSRCp9ekFucwMY0wEb/qHjy9roDWWDv7ih9b
WPqIPKPv/nuWX7hOqWXAyrkmyeTKS8nhRrf2jBSKSVhm/uGpKiB9Q2i1+7SYSIDf
OPzO+RmDeQuFRiTrAeUrTxz+qyEfbnlWer5ZyEGDNssV6TQQHSwEkYxyhc9jsoE6
xz5AeF2DhV04rM9m9qk5dBPAN8YWTJK7xqE1MC9lQ/UZp35jhryvChbnWbWAC49M
k8xe5AfrDDWclBfSbCeyoISuTNq9m2KLHbNAAhCqPWZFWgT/7rY9QnRxFXNsjPvr
Vr2kfpBy0oR7JEFS4YZvUkVNgDUopgCEEwi5b4wdm6X/NeUHfInfq9DLvyOKeDGa
LY0hazSYNxi4c7ek0TvR1APZEDcN7LVdi3XDc5A3b/y6zcSwhesMCFKro88QDvEO
YwTqznU3gwRPMyAhrINnJIfOdrgLMC8iwqtNDrDqCTJmxGBhTlbRueVXhBcJ9ue9
7i4pdfTx6KVRBVDJNQfp1krITYv6KbqqbqZE4Hui6knXdfamWBkQaCf7uLy4GGv9
RIATMrUBOZK8YNUwIiaaCl+N8X2MybEf7OayWNQsqtkEj7FRX6yR7vNY1rtXprGa
Mfc5QPR0ZmEcbjscpws/
=ZS2K
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.