Debian Bug report logs - #788585
dsh: overwrites host list with a symlink

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Christoph Anton Mitterer <calestyo@scientia.net>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: dsh: overwrites host list with a symlink

Date: Sat, 13 Jun 2015 01:04:58 +0200

Package: dsh
Version: 0.25.10-1.1
Severity: critical
Justification: causes serious data loss



Hi.

dsh installs the file /etc/dsh/group/all as a symlink to "../machines.list".

Since I didn't like the way that all host lists would be in /etc/dsh/group/
and just the -a list is in /etc/dsh/machines.list I reverted that to:
- /etc/dsh/group/all being the regular file
- /etc/dsh/machines.list being the symlink to the former

In violation of the policy, /etc/dsh/group/all is not a conffile,
thus the host list, with precious data, is removed without further
asking and installation of the package yields an error:
Setting up dsh (0.25.10-1.1) ...
dpkg: warning: dsh: config file '/etc/dsh/machines.list' is a circular link
 (= '/etc/dsh/group/../group/../group/../group/../group/../group/../group/../group/../group/../group/../group/../group/../group/all')



Chris.

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.0.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_DE.UTF-8, LC_CTYPE=en_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Message #10 received at 788585@bugs.debian.org (full text, mbox, reply):

From: Andreas Bombe <aeb@debian.org>

To: Christoph Anton Mitterer <calestyo@scientia.net>

Cc: 788585@bugs.debian.org, control@bugs.debian.org

Subject: Re: Bug#788585: dsh: overwrites host list with a symlink

Date: Sun, 22 Nov 2015 16:32:34 +0100

severity 788585 grave
block 788585 by 421344
thanks


(Severity reduced to grave since the data loss does not extend beyond
files associated with the package.)


On Sat, Jun 13, 2015 at 01:04:58AM +0200, Christoph Anton Mitterer wrote:
> Hi.
> 
> dsh installs the file /etc/dsh/group/all as a symlink to "../machines.list".
> 
> Since I didn't like the way that all host lists would be in /etc/dsh/group/
> and just the -a list is in /etc/dsh/machines.list I reverted that to:
> - /etc/dsh/group/all being the regular file
> - /etc/dsh/machines.list being the symlink to the former
> 
> In violation of the policy, /etc/dsh/group/all is not a conffile,
> thus the host list, with precious data, is removed without further
> asking and installation of the package yields an error:
> Setting up dsh (0.25.10-1.1) ...
> dpkg: warning: dsh: config file '/etc/dsh/machines.list' is a circular link
>  (= '/etc/dsh/group/../group/../group/../group/../group/../group/../group/../group/../group/../group/../group/../group/../group/all')

The symlink is not marked as a conffile because debhelper (specifically
dh_installdeb) does not mark symlinks to be installed in /etc as
conffiles. According to #421346 this is intentional as dpkg does not
work correctly with conffile symlinks (#421344, #690051). Thus the
apparent fix of marking it as a conffile explicitly is likely unwise.

Message #19 received at 788585@bugs.debian.org (full text, mbox, reply):

From: Ivo De Decker <ivodd@debian.org>

To: Andreas Bombe <aeb@debian.org>

Cc: Christoph Anton Mitterer <calestyo@scientia.net>, 788585@bugs.debian.org

Subject: Re: Bug#788585: dsh: overwrites host list with a symlink

Date: Thu, 6 Apr 2017 22:58:58 +0200

Hi,

On Sun, Nov 22, 2015 at 04:32:34PM +0100, Andreas Bombe wrote:
> The symlink is not marked as a conffile because debhelper (specifically
> dh_installdeb) does not mark symlinks to be installed in /etc as
> conffiles. According to #421346 this is intentional as dpkg does not
> work correctly with conffile symlinks (#421344, #690051). Thus the
> apparent fix of marking it as a conffile explicitly is likely unwise.

The workaround is to stop shipping the symlink in the package, but create it
in postinst (and remove it on purge in postrm). This probably needs some care
to handle the upgrade.

Cheers,

Ivo

Message #24 received at 788585@bugs.debian.org (full text, mbox, reply):

From: Ivo De Decker <ivodd@debian.org>

To: Ivo De Decker <ivodd@debian.org>

Cc: Andreas Bombe <aeb@debian.org>, Christoph Anton Mitterer <calestyo@scientia.net>, 788585@bugs.debian.org

Subject: Re: Bug#788585: dsh: overwrites host list with a symlink

Date: Sun, 9 Apr 2017 00:24:16 +0200

[Message part 1 (text/plain, inline)]

Control: tags -1 patch pending

Hi,

On Thu, Apr 06, 2017 at 10:58:58PM +0200, Ivo De Decker wrote:
> On Sun, Nov 22, 2015 at 04:32:34PM +0100, Andreas Bombe wrote:
> > The symlink is not marked as a conffile because debhelper (specifically
> > dh_installdeb) does not mark symlinks to be installed in /etc as
> > conffiles. According to #421346 this is intentional as dpkg does not
> > work correctly with conffile symlinks (#421344, #690051). Thus the
> > apparent fix of marking it as a conffile explicitly is likely unwise.
> 
> The workaround is to stop shipping the symlink in the package, but create it
> in postinst (and remove it on purge in postrm). This probably needs some care
> to handle the upgrade.

I prepared an NMU that does that (patch attach). I will upload it shortly.

Cheers,

Ivo

[dsh_788585.debdiff (text/plain, attachment)]

Message #31 received at 788585-close@bugs.debian.org (full text, mbox, reply):

From: Ivo De Decker <ivodd@debian.org>

To: 788585-close@bugs.debian.org

Subject: Bug#788585: fixed in dsh 0.25.10-1.3

Date: Sat, 08 Apr 2017 22:49:35 +0000

Source: dsh
Source-Version: 0.25.10-1.3

We believe that the bug you reported is fixed in the latest version of
dsh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 788585@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Ivo De Decker <ivodd@debian.org> (supplier of updated dsh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 08 Apr 2017 23:58:21 +0200
Source: dsh
Binary: dsh
Architecture: source amd64
Version: 0.25.10-1.3
Distribution: unstable
Urgency: medium
Maintainer: Junichi Uekawa <dancer@debian.org>
Changed-By: Ivo De Decker <ivodd@debian.org>
Description:
 dsh        - dancer's shell, or distributed shell
Closes: 788585
Changes:
 dsh (0.25.10-1.3) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Don't ship symlink for /etc/dsh/group/all. (Closes: #788585)
Checksums-Sha1:
 e147b900f5b0ed3eeb7d908a57aeaca7fb415909 1656 dsh_0.25.10-1.3.dsc
 b2df348179220d57115d501be4d1e8752d577e14 12626 dsh_0.25.10-1.3.diff.gz
 d9cca23a1da0a01423831865b7d73c51ba6aee51 4751 dsh_0.25.10-1.3_amd64.buildinfo
Checksums-Sha256:
 f57a86969c5a352694f53e9818ad459e7dd54804bdc57b235b9b6135c39d8802 1656 dsh_0.25.10-1.3.dsc
 7ee25929b945c0a22c9fa35902b02d3576c2909a1b7019812511932f9ac62e66 12626 dsh_0.25.10-1.3.diff.gz
 375c7aa109899fc909b23fcf3c9ae9fa295c03b2612f1997df205ce80b3f30ed 4751 dsh_0.25.10-1.3_amd64.buildinfo
Files:
 a1258733139d21da38951284e21acfb7 1656 net optional dsh_0.25.10-1.3.dsc
 6a5dad5b7a5b0dc4210d2be621d543b0 12626 net optional dsh_0.25.10-1.3.diff.gz
 c6c3069a8dbb1384d7857900fde71c17 4751 net optional dsh_0.25.10-1.3_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJY6WRiAAoJEKxAu1iXBOr8ls0QAIXvsilW31IpLod9MQ1Z5NV5
GuQScdqqs8/fMEHc/UKi07ciKKrJCieuLhIML201y0LR+Ds27sJIMZvJZS9fHyZa
Eq3PpttpyNzmGzZA8YLb0P/ltVNgIF7gCfNNdSD7Xw4KZhkzxmUosKIFd66gq4nK
8rDIXFdctTFJLT+PCj2BqDTWDfIqEPeVPdLFSPHdtQTN9Q0UXMs2HlWahKcob5EC
51q6sZ7nIxriQQs2bXpIFm0e5e4svtSMUsNW/8YciN3NjAN59j/gqxuVU7tPqcl8
dkAd9HF69cF8QrphbReLIPaomcV1tfBw24OsbaUk/hYwm3KmOXRP/SQhTQrBGdWj
ucx3xlKH1t4fiuQVkIXRvbp+a3TjgPGEWqpz1FuOvTnAocrTcIpaw0xFF2P9QEEj
uRHP/fzPTkh4NYkug7jnihYyWS9HoFj5+TCJ6yHeGVMQUvXtFfxZ0rHSUPvm+HSG
IFEQYNOMweCe0DWAnJCFkpAKcU/bWUwehs0PrTD+c5CqRfexXmjGQJhDHOiW+ZA4
FrOVPsEWnk6doVJSCDTXEz0ybdEJPZtceLLF59k+KBaVUX91AQUZ72cDMMXMk7/P
NsLmDrsy0L4Vrm30gtTtKsX5uxFXWp/CxE8CJLe6/cQjKsTVH4uO2MUSqZmhI8kZ
sD4I1HUQhRASGzHHR2VC
=NJNV
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.