Debian Bug report logs - #720163
s-s-d: Should clean up environment

Reply or subscribe to this bug.

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Klaus Ethgen <Klaus@Ethgen.de>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: start-stop-daemon should clean up environment

Date: Mon, 19 Aug 2013 10:46:14 +0100

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Package: dpkg
Version: 1.17.1
Severity: normal

To have a reproducible daemon, the daemons started by start-stop-daemon
should have cleaned environment, for example the language environments
LANG and LC_*.

Not doing so ends in strange behaviour of the daemons depending which
admin with different personal language settings started it.

Namely that is:
- - LC_*
- - LANG*
- - *LOCALE
- - evtl. LD_LIBRARY_PATH
- - TZ
- - ...

Some of the environments get used by sshd from the client machine if one
logs in by ssh.

The best would be to have a fully controlled environment for daemons.
But this would be a big step.

- -- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (800, 'unstable'), (600, 'oldstable'), (110, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.9.4 (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=de_DE, LC_CTYPE=de_DE (charmap=ISO-8859-1) (ignored: LC_ALL set to de_DE)
Shell: /bin/sh linked to /bin/dash

Versions of packages dpkg depends on:
ii  libbz2-1.0   1.0.6-4
ii  libc6        2.17-92
ii  liblzma5     5.1.1alpha+20120614-2
ii  libselinux1  2.1.13-2
ii  tar          1.26+dfsg-6
ii  zlib1g       1:1.2.8.dfsg-1

dpkg recommends no packages.

Versions of packages dpkg suggests:
ii  apt  0.9.9.4

- -- no debconf information

- -- 
Klaus Ethgen                              http://www.ethgen.ch/
pub  4096R/4E20AF1C 2011-05-16   Klaus Ethgen <Klaus@Ethgen.de>
Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iQGcBAEBCgAGBQJSEeljAAoJEKZ8CrGAGfas9QsL/iWq5JV36GmyAyOHg4f660sc
qmpBhoQq2dIl4zkIfCJLmi2nWobXFPARVQKcRSen8E0G7Y57ixHuWo1E3T80idNX
BvHyOnkb3+Nifs2+NyGcK4r222g4szwfEZmR9b5zbmIbN/pzhAdCZAMJ1IeIeI91
4+DoJYUIpymx/3Anwc0iGJZ30hAC2xESgRQzezWPBVNFzvqdjGhG35HOSQx5h2oK
sJxuLUbZOciPRVguZmS0vMtW9VUR4oc2hCnveBr2In7mSVl4ooW0eWMtzp88ega0
mWvsvUDTczkUpGm7TMU3h9pR+hw8g3SsynejTB8aIuoR5rNC5XRzzOKWjKFKLQHW
Ma0kDBDhgQCh4g9tMrjnQcLd4Dz3fOyCFxEFCznpj632bTl9JqoMAUsFQ3iRo+DX
1yLXEiDK2jjVteBV8xyt3w181DtSuCNP/IPxsWW/5uWmOfhV6eo5v7YuPDtZxzhn
Mef8ao6iPxb9ZtnwgFSmBkksYtNJuULqDFDWyRpU3Q==
=ZIF0
-----END PGP SIGNATURE-----

Message #10 received at 720163@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: Klaus Ethgen <Klaus@Ethgen.de>, 720163@bugs.debian.org

Subject: Re: Bug#720163: start-stop-daemon should clean up environment

Date: Mon, 19 Aug 2013 12:52:12 +0200

Hi!

On Mon, 2013-08-19 at 10:46:14 +0100, Klaus Ethgen wrote:
> Package: dpkg
> Version: 1.17.1
> Severity: normal
> 
> To have a reproducible daemon, the daemons started by start-stop-daemon
> should have cleaned environment, for example the language environments
> LANG and LC_*.
> 
> Not doing so ends in strange behaviour of the daemons depending which
> admin with different personal language settings started it.
> 
> Namely that is:
> - LC_*
> - LANG*
> - *LOCALE
> - evtl. LD_LIBRARY_PATH
> - TZ
> - ...
> 
> Some of the environments get used by sshd from the client machine if one
> logs in by ssh.
> 
> The best would be to have a fully controlled environment for daemons.
> But this would be a big step.

I see the problem and I agree that something should be done about it,
but as I mentioned in [0], I don't think the right place to plug a
global distribution environment policy is s-s-d, because using it is
not required by the debian-policy and as such some daemons might not
be using it to start.

  <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=631081#58>

Adding support for some kind of controls on the process environment to
s-s-d might make sense, but not in the way you present here.

Thanks,
Guillem

Message #15 received at 720163@bugs.debian.org (full text, mbox, reply):

From: Klaus Ethgen <Klaus@Ethgen.de>

To: Guillem Jover <guillem@debian.org>

Cc: 720163@bugs.debian.org

Subject: Re: Bug#720163: start-stop-daemon should clean up environment

Date: Mon, 19 Aug 2013 12:02:27 +0100

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Moin,

Am Mo den 19. Aug 2013 um 11:52 schrieb Guillem Jover:
> I see the problem and I agree that something should be done about it,
> but as I mentioned in [0],

Where is that [0]?

> I don't think the right place to plug a global distribution
> environment policy is s-s-d, because using it is not required by the
> debian-policy and as such some daemons might not be using it to start.

It might not be but it could be a good place for it.

>   <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=631081#58>

Is this the [0]?

> Adding support for some kind of controls on the process environment to
> s-s-d might make sense, but not in the way you present here.

Well, it is just a first Idea to get around such bugs. I have no
solutions at the moment. For my company I created a job scheduler in
perl that is cleaning up the environment and taking full control over
it. This might be no good idea for s-s-d, but somewhat in between ...

Regards
   Klaus
- -- 
Klaus Ethgen                              http://www.ethgen.ch/
pub  4096R/4E20AF1C 2011-05-16   Klaus Ethgen <Klaus@Ethgen.de>
Fingerprint: 85D4 CA42 952C 949B 1753  62B3 79D0 B06F 4E20 AF1C
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)

iQGcBAEBCgAGBQJSEftCAAoJEKZ8CrGAGfasQvAL/3n3kA753soCXGSlMn8V4ZGb
zQrqVbt1VCrEyQVE04pi5t6Q/0ZsWRzOSgdkKhwJCN/pz3wBzNXEk4EZ/OYN9X2t
0FuJmsE4jpjlpKywO+A6jL5CBOUKISvi3anlDQayjVtP2Ltn3SMpGQ8REPT94S3/
uuJCb0EAIk2J3CcWasLVjO65OH1OjMeHWhJxEon23vuO6/sovL4tXccgeujuDhxe
HHT5Sg3+jm1zM7bKxyoENRsHPVjKLkVzvR4hXUgLzQVZnejjuG0Wh8u5yZCUkgkV
e3NMQzmGwt8vTrh9zkigNnuC+9OXVk8qk22RrHyFtmUhUiggqOax07neCe+S6lXM
nc4evMu05PSCt31w3X1Fmq9fQap3E1mcRSV8mFLVkzg9r7Ctrip/KEtLfrAq9wlq
6nd2RQZ7t1TCHXNnJpkovIlPkGROXBHJCR+zAEmcqGq5RCT7k1WCodN5tC9/TDf0
+EU5P3S1ScIaxRYnz9JeBBXM0BhyQc9fz+6t8YmcoQ==
=oxzx
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.