Debian Bug report logs - #698723
lintian: Error on different trigger directives for the same trigger-name

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: submit@bugs.debian.org

Subject: lintian: Error on different trigger directives for the same trigger-name

Date: Tue, 22 Jan 2013 19:50:39 +0100

Package: lintian
Version: 2.5.12
Severity: wishlist

Hi!

Due to 537051 we noticed that the documentation for the triggers
control file directives is not really clear. Using the two different
directives for the same trigger names is pretty confusing as only the
last one will be honoured. Things like this in the .deb triggers
control file:

,--- DEBIAN/triggers
| interest-noawait foo
| interest foo
`---

would only add a non-awaiting trigger to the dpkg database. The same
goes for activate-noawait/activate. Ideally dpkg would contain better
documentation explaining this, and the code would make sure this never
happens at build time, and warn at unpack time, etc. For further
details of the situation that brought up this, read starting at:

  <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537051#90>

So it would be nice if lintian could emit an error tag for those
conditions. I've added to my TODO to improve this for dpkg 1.17.x,
but even then the lintian check would still be useful as there might
be packages in the wild with stuff like the above.

Thanks,
Guillem

Message #10 received at 698723@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: Guillem Jover <guillem@debian.org>, 698723@bugs.debian.org

Subject: Re: Bug#698723: lintian: Error on different trigger directives for the same trigger-name

Date: Tue, 22 Jan 2013 20:38:09 +0100

On 2013-01-22 19:50, Guillem Jover wrote:
> Package: lintian
> Version: 2.5.12
> Severity: wishlist
> 
> Hi!
> 

Hi,

> Due to 537051 we noticed that the documentation for the triggers
> control file directives is not really clear. Using the two different
> directives for the same trigger names is pretty confusing as only the
> last one will be honoured. Things like this in the .deb triggers
> control file:
> 
> ,--- DEBIAN/triggers
> | interest-noawait foo
> | interest foo
> `---
> 
> would only add a non-awaiting trigger to the dpkg database. The same
> goes for activate-noawait/activate. Ideally dpkg would contain better
> documentation explaining this, and the code would make sure this never
> happens at build time, and warn at unpack time, etc. For further
> details of the situation that brought up this, read starting at:
> 
>   <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537051#90>
> 

When you say the "only last one will be honoured" does mean that an
"interest foo" and "activate foo" can override each other (or is that a
separate namespace).  I understand that interest is for file names and
activate is not, but just for getting the case right.

> So it would be nice if lintian could emit an error tag for those
> conditions. I've added to my TODO to improve this for dpkg 1.17.x,
> but even then the lintian check would still be useful as there might
> be packages in the wild with stuff like the above.
> 
> Thanks,
> Guillem
> 
> 

~Niels

Message #15 received at 698723@bugs.debian.org (full text, mbox, reply):

From: Guillem Jover <guillem@debian.org>

To: Niels Thykier <niels@thykier.net>

Cc: 698723@bugs.debian.org

Subject: Re: Bug#698723: lintian: Error on different trigger directives for the same trigger-name

Date: Thu, 24 Jan 2013 13:45:44 +0100

On Tue, 2013-01-22 at 20:38:09 +0100, Niels Thykier wrote:
> On 2013-01-22 19:50, Guillem Jover wrote:
> > Due to 537051 we noticed that the documentation for the triggers
> > control file directives is not really clear. Using the two different
> > directives for the same trigger names is pretty confusing as only the
> > last one will be honoured. Things like this in the .deb triggers
> > control file:
> > 
> > ,--- DEBIAN/triggers
> > | interest-noawait foo
> > | interest foo
> > `---
> > 
> > would only add a non-awaiting trigger to the dpkg database. The same
                  ^an awaiting
> > goes for activate-noawait/activate. Ideally dpkg would contain better
> > documentation explaining this, and the code would make sure this never
> > happens at build time, and warn at unpack time, etc. For further
> > details of the situation that brought up this, read starting at:
> > 
> >   <http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=537051#90>

> When you say the "only last one will be honoured" does mean that an
> "interest foo" and "activate foo" can override each other (or is that a
> separate namespace).  I understand that interest is for file names and
> activate is not, but just for getting the case right.

Ah, sorry about the poor description. Both interest and activate
directives can work with explicit triggers and file triggers. I should
have said “using two different variants of the same directive for the
same trigger name”, let me show some examples to try to clarify:

Different directives for different trigger-names are fine and normal.

,--- ok
  activate foo-a
  interest-noawait /path/to/a
  interest /path/to/b
  activate-noawait foo-b
`---

And ah, nice! now that you mention it, different directives (interest
or activate of any variant) for the same trigger-name is suspect, dpkg
will not activate triggers for a package that's interested in itself,
as the trigger will be activated during unpack which ignores those.
This should be a warning, because even if this does not make much sense
semantically, it could be legimitate (?) if other packages might
activate or might be interested in the same trigger-name, perhaps.

,--- hmmm, suspect but could be okish
  activate explicit-name-a
  interest-noawait explicit-name-a
`---

Different variants of the same directive are always problematic. The
following cases should be errors, as relying on undefined behaviour:

,--- not ok
  interest-noawait explicit-name-a
  interest explicit-name-a
  interest /path/to/a
  interest-noawait /path/to/a
`---

,--- not ok
  activate explicit-name-a
  activate-noawait explicit-name-a
  activate-noawait /path/to/a
  activate /path/to/a
`---


Hope this clarifies.

Thanks,
Guillem

Message #22 received at 698723-close@bugs.debian.org (full text, mbox, reply):

From: Niels Thykier <niels@thykier.net>

To: 698723-close@bugs.debian.org

Subject: Bug#698723: fixed in lintian 2.5.51

Date: Sun, 18 Jun 2017 09:18:52 +0000

Source: lintian
Source-Version: 2.5.51

We believe that the bug you reported is fixed in the latest version of
lintian, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 698723@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Niels Thykier <niels@thykier.net> (supplier of updated lintian package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 18 Jun 2017 07:57:57 +0000
Source: lintian
Binary: lintian
Architecture: source
Version: 2.5.51
Distribution: unstable
Urgency: medium
Maintainer: Debian Lintian Maintainers <lintian-maint@debian.org>
Changed-By: Niels Thykier <niels@thykier.net>
Description:
 lintian    - Debian package checker
Closes: 540294 633850 645455 695345 698723 814521 815233 829649 848878 849470 849880 851215 852005 852084 852145 852369 852404 852407 852409 852410 852411 852413 852414 852416 852419 852421 852426 852891 854132 855243 856155 856312 856857 856954 856975 857194 857654 857655 857656 858117 858326 859412 859467 860419 860558 861509 861599 861958 863020 863386
Changes:
 lintian (2.5.51) unstable; urgency=medium
 .
   * Summary of tag changes:
     + Added:
       - debian-control-has-dbgsym-package
       - debian-control-has-obsolete-dbg-package
       - debian-rules-parses-dpkg-parsechangelog
       - desktop-entry-lacks-icon-entry
       - distribution-and-changes-mismatch
       - distribution-and-experimental-mismatch
       - gir-in-arch-all-package
       - gir-missing-typelib-dependency
       - gir-section-not-libdevel
       - multiarch-foreign-shared-library
       - r-data-without-readme-source
       - readme-source-is-dh_make-template
       - repeated-trigger-name
       - systemd-service-file-refers-to-obsolete-bindto
       - testsuite-autopkgtest-missing
       - typelib-in-arch-all-package
       - typelib-missing-gir-depends
       - typelib-not-in-multiarch-directory
       - typelib-package-name-does-not-match
       - typelib-section-not-introspection
       - unknown-trigger
       - unreleased-changes
       - uses-implicit-await-trigger
     + Removed:
       - ancient-autotools-helper-file
       - init.d-script-missing-dependency-on-remote_fs
       - maintainer-script-should-not-use-ancient-dpkg-epoch-check
       - maintainer-script-should-not-use-ancient-dpkg-multi-conrep-check
       - outdated-autotools-helper-file
       - package-would-benefit-from-build-arch-targets
       - suidregister-used-in-maintainer-script
 .
   * checks/binaries.{desc,pm}:
     + [NT] Apply patch from Adrian Bunk to bump severity of the
       hardening-no-pie to a W-tag and improve the tag description.
       (Closes: #856155)
     + [NT] Apply patches from Michael Stapelberg to improve handling
       of golang binaries.  (Closes: #857654, #857655, #857656)
   * checks/changelog-file.pm:
     + [BR] Check also bug over 1000000 as improbable. Bug below
       50004 are not archived and are thus improbable.
   * checks/changes-file.{desc,pm}:
     + [BR] Apply patch by Simon McVittie to detect unreleased package
       uploaded to unstable and  mismatched .changes and
       Changes: distribution.  (Closes: #540294).
   * checks/control.{desc,pm}:
     + [BR] Detect dbgsym package in control file.  (Closes: #858117).
     + [BR] Warn about obsolete -dbg package.
   * checks/cruft.{desc,pm}:
     + [BR] Document long line tagged source-is-missing as a feature
       not a bug.  (Closes: #849470).
     + [BR] Correct a typo in description of tag
       license-problem-convert-utf-code.
     + [BR] Avoid a false positive in gfdl file detection.
     + [NT] Drop tags about outdated autotools config.guess and
       config.sub files.  These days debhelper automatically updates
       them when people use the dh-sequencer and the check is not
       geared for more thorough analysis.  (Closes: #848878)
     + [CL] Check that README.source is not the dh_make template.
       (Closes: #633850)
   * checks/debian-readme.{desc,pm}:
     + [NT] Locate the README.Debian using the index rather than relying
       on a collection.
   * checks/fields.pm:
     + [BR] Enforce naming convention for debug package.  (Closes: #645455).
     + [NT] Avoid proposing "/git/git/" as a part of the canonical URL for
       anonscm.debian.org.  Thanks to Andreas Beckmann for spotting the
       bug.  (Closes: #851215)
     + [NT] Apply patch from Dylan Aïssi to recommend "javascript" section
       for libjs packages.  Previously, lintian would recommend "web".
       (Closes: #863386)
   * checks/files.pm:
     + [BR] Do not report duplicates for package-installs-apt-preferences
       and package-installs-apt-sources.  (Closes: #814521).
     + [NT] Apply patch from Helmut Grohne to detect some possible invalid
       uses of "Multi-Arch: foreign".  (Closes: #856975)
     + [NT] Improve the empty-binary-package tag by adding more common
       files that should be ignored.  Thanks to Helmut Grohne for all the
       research behind it.  (Closes: #856857)
     + [BR] Detect symlink pointing to builddir.  (Closes: #860419)
     + [CL] Detect RData without README.source.  (Closes: #815233)
     + [NT] Remove work around for segmentation faults in t1disasm from
       t1utils (<< 1.38-4~).  Given Jessie is the minimum supported Debian
       version, we can now assume t1utils to be (>= 1.38-4).
   * checks/gir.{desc,pm}:
     + [NT] Add check for gir packages written by Simon McVittie.
       (Closes: #695345)
   * checks/init.d.{desc,pm}:
     + [NT] Remove check for init.d scripts accessing /usr without a
       $remote_fs dependency as /usr must now be mounted by the initramfs.
       (Closes: #829649)
   * checks/menu-format.{desc,pm}:
     + [NT] Update the reference to Desktop Entry Specification to point
       to version 1.1.
     + [NT] Apply patch from Laurent Bigonville to check desktop files
       for missing "Icon" field.  (Closes: #854132)
   * checks/rules.{desc,pm}:
     + [NT] Drop "package-would-benefit-from-build-arch-targets".  The
       dpkg-buildpackage refuses to build packages that trigger this tag.
       Also, the tag implies two other "W" tags so contributors are still
       notified of a potential problem.
     + [CL] Check for manual parsing of dpkg-parsechangelog output now that
       we have /usr/share/dpkg/pkg-info.mk.
   * checks/scripts.{desc,pm}:
     + [NT] Apply patch from Christopher Hoskin to except -doc packages
       from the "new-package-should-not-package-python2-module" tag.
       (Closes: #855243)
     + [NT] Remove references to tags about calling suidregister,
       dpkg --assert-working-epoch, and dpkg --assert-multi-conrep from
       maintainer scripts.
   * checks/systemd.{desc,pm}:
     + [NT] Apply patch from Michael Biebl to warn about deprecated
       "BindTo" option in systemd service files.  (Closes: #857194)
   * checks/testsuite.{desc,pm}:
     + [NT] Apply patch from Lucas Kanashiro to add a tag for recommending
       packagers to create an autopkgtest for their package.
       (Closes: #859467)
     + [NT] Fix false-positive "missing-runtime-test-file" when the
       "Tests-Directory" field is set to a single dot.  Thanks to
       Ian Jackson for reporting the issue.  (Closes: #849880)
   * checks/triggers.{desc,pm}:
     + [NT] New check.  (Closes: #698723)
   * checks/upstream-metadata.pm:
     + [JW, NT] Disable YAML parsing of upstream metadata file as the YAML
       parser executes code.  (Closes: #861958, CVE-2017-8829)
   * checks/watch-file.pm:
     + [NT] Apply patch from Alexander Kulak to handle whitespace correctly
       in the options in v4 watch files.  (Closes: #861599)
 .
   * coll/debian-readme{,desc}:
     + [NT] Remove.  Merge what little functionality it offers into the
       debian-readme check.
 .
   * commands/{lintian => lintian.pm}:
     + [NT] Turn the lintian frontend into a dplint command module to avoid
       code duplication.
   * commands/reporting-*:
     + [NT] Rewrite the config file handling.  The reporting framework now
       uses a YAML configuration file instead of a perl script.
     + [NT] Support processing packages from multiple archives and different
       suites in these archives.  This enables lintian.d.o to also process
       dbgsym packages.  (Closes: #856312)
 .
   * data/changes-file/known-dists:
     + [NT] Add buster and remove squeeze.
   * data/common/source-fields:
     + [NT] Add new "Testsuite-Restrictions" field.
   * data/files/privacy-breaker-websites:
     + [BR] Add digit.com as tracker.
     + [BR] Add static.ak.fbcdn.net as facebook.
     + [BR] Add forkme as logo.
   * data/files/standard-files:
     + [NT] Add more common files based on feedback from Helmut Grohne.
   * data/obsolete-sites/obsolete-sites:
     + [BR] Apply patch from Hideki Yamane in order to warn about
       fedorahosted.  (Closes: #856954).
     + [NT] Apply patch from Hideki Yamane to warn about codeplex.com
       closing down.  (Closes: #859412).
   * data/scripts/interpreters:
     + [NT] Add stap as a known interpreter.  Thanks to gustavo panizzo
       for the suggestion.  (Closes: #858326)
   * data/scripts/maintainer-script-bad-command:
     + [NT] Remove check for suidregister, dpkg --assert-working-epoch, and
       dpkg --assert-multi-conrep.  None of these trigger any tags in the
       archive any longer and the (new) features have been available for
       8+ years.
   * data/spelling/corrections:
     + [NT] Apply patches from Edward Betts to fix bugs in the correction
       word lists.  (Closes: #852005, #852084)
     + [NT] Apply patch from Edward Betts to remove corrections for
       "targetted" and "targetting" as they are valid alternative
       spellings in AU.  (Closes: #852145)
     + [EB] Add some more spelling corrections.  (Closes: #852369, #852404,
       #852407, #852409, #852410, #852411, #852413, #852414, #852416,
       #852419, #852421, #852426)
     + [CL] Add "none were" -> "none was" multiword spelling correction.
       (Closes: 860558)
   * data/standards-version/release-dates:
     + [NT] Add 4.0.0 as a known standards version along with its release
       date.
 .
   * debian/control:
     + [NT] Add explicit (Build-)Depends on dpkg (>= 1.17.14) to make it
       explicit that we no longer support Wheezy or older.
     + [NT] Drop versioned dependencies that are there to assist to
       Wheezy.
     + [NT] Mention Debian Policy v4.0.0 in the description.
     + [NT] Bump Standards-Version to 4.0.0 - no changes required.
   * debian/copyright:
     + [EB] Add Edward Betts.
 .
   * frontend/dplint:
     + [NT] Ensure all include directories are absolute before passing
       them on to the actual command.
     + [NT] Work around a "Bizarre Copy" bug in perl that could trigger
       on errors.
 .
   * lib/Lintian/CheckScript.pm:
     + [NT] Remove fallback code for "old" style "pm"-less checks.
   * lib/Lintian/Util.pm:
     + [NT] Drop dpkg_deb_has_ctrl_tarfile.  Lintian now assumes that
       dpkg 1.17.14 is available (provided by Debian jessie or later).
 .
   * reporting/{config => config.yaml}:
     + [NT] Rewrite the reporting config template into the new YAML format.
   * reporting/graphs/tags.gpi:
     + [NT] Tweak tags.gpi so it works with gnuplot 5.
   * reporting/templates/{index.tmpl,lintian.css.tmpl}:
     + [NT] Update to support multiple archives.
 .
   * t/*:
     + [NT] Drop "Test-Depends" from tests where the versions in Debian
       jessie will satisfy the dependency.
     + [NT] Update tests to fix FTBFS caused by dpkg-source now ignoring
       debian/files by default.  (Closes: #863020)
   * t/runtests:
     + [NT] Re-sort test output after running the "post_test" sed script
       on the output.  This prevent test failures caused by the order
       changing on different architectures prior to the sed script is run
       (assuming the sed script otherwise normalises the differences
       correctly).
   * t/tests/cruft-general-upstream/pre_upstream:
     + [EB] Fix failing tests by making the fake flash object more
       convincing.  The most recent version of libmagic uses a more precise
       definition of the data within a flash file.  (Closes: #852891)
   * t/tests/java-jars:
     + [NT] Provide a more convincing corrupt .zip file that also fools
       file 5.30.
 .
   * vendors/ubuntu/main/data/changes-file/known-dists:
     + [CW] Add zesty.
     + [NT] Apply patch from "Unit 193" to add "devel" as a known Ubuntu
       distribution.  (Closes: #861509)
     + [NT] Add artful.
Checksums-Sha1:
 9958814b241b14a8c8bfde5a8648e55e61ffc87a 2798 lintian_2.5.51.dsc
 1124965ea2017a7527fbe20c9c40f4162a835347 1223124 lintian_2.5.51.tar.xz
 5c2c6f419d1bb54e3ee3a69f22b0623bafa917d1 17473 lintian_2.5.51_source.buildinfo
Checksums-Sha256:
 f03ef8831439f33a38e8bb495653075e996485f4f66a1fcf25e00ff06dfdd783 2798 lintian_2.5.51.dsc
 608747cf4c7277673b02e1ea0964234f3e46e80bcc43fa7d39427fd49946dd77 1223124 lintian_2.5.51.tar.xz
 9db4c5037eae541fbf23e95333292c698643a7895b0e1d8bf2cadcaff3db7281 17473 lintian_2.5.51_source.buildinfo
Files:
 2516131ac63f745a7e2ce279419f6dc0 2798 devel optional lintian_2.5.51.dsc
 de06a374f50bcd6441e7995b1bcc7f21 1223124 devel optional lintian_2.5.51.tar.xz
 379b2de6ac61b0b09312264efcfd0964 17473 devel optional lintian_2.5.51_source.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEsxMaRR2/33ygW0GXBUu7n32AZEIFAllGOxcACgkQBUu7n32A
ZEIwUxAAoGn6TvnVNYgzUQ589TpO9aCDVDJ3AHcbsua/l/fH8b0KBvwa/VV6j6Ua
YTSxHVsEfTskG4hbQmUsny0hRXU2jDAWi3PCRE8UHRuVYqGeXGmLF85+bGetpO8d
Z6IgU2i8QnN+JwL1W/sUdLjnguw726A3KhufquK+p9p18/em17CaRSlv0ZM68Km2
izZqkDJZ0n668NXmfxbqiQJSqaV39AnS2cXmLLPhDE9KSlMx5axJln3oADXSaGdS
G6arHbYlNzCKFVnM7C/WbE8i6ql+45Aqta4byeOr/aUZoQcGwgnHn2SfTrCpRhEL
S9wMmFDsgpcDn4Rpq9OrzUk+O+MV91azffAEf0rWFrUzUUKGkt7VLWos+Xhxu3rK
pnF2rU4mWpCPVJOwvXysKsW51qQvU+XimBLAKAesZne9SsYeVjyEg3t2FP6iiqVX
glvToxyNYJZZtdeWsE6wocNfn3nP/1nfL6RlKUsnLb9qfYXONJwP4PusdSebfwfb
+MQbkEiqyZI6CT62nJ2rYIF+K4HuGMfv/lyVzfy7pQ1CEufpGDJj4h8ECjEoG2sW
H7Uy4625iZeW6hvdCBtwKVsaZZaEqOHF277wJvGjis2D1h6ej6Lo6zbRG8kc0T50
xHUHuNs4XfnLjQy8858h+KIjpWek5s3Nfx3ahZWqlyQYvB2WJN4=
=ty20
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.