Debian Bug report logs - #1039408
uwsgi: ships sysv-init script without systemd unit

Display info messages

Message #5 received at maintonly@bugs.debian.org (full text, mbox, reply):

From: bluca@debian.org

To: maintonly@bugs.debian.org

Subject: uwsgi: ships sysv-init script without systemd unit

Date: Sun, 25 Jun 2023 23:34:31 +0100

Package: uwsgi
Severity: important
User: bluca@debian.org
Usertags: missing-systemd-service

Dear Maintainer(s),

uwsgi has been flagged by Lintian as shipping a sysv-init script
without a corresponding systemd unit file. The default init system in
Debian is systemd, and so far this worked because a transitional
sysv-init-to-unit generator was shipped by systemd. This is in the
process of being deprecated and will be removed by the time Trixie
ships, so the remaining packages that ship init scripts without
systemd units will stop working.

There are various advantages to using native units, for example the
legacy generator cannot tell the different between a oneshot service
and a long running daemon. Also, sanboxing and security features
become available for services. For more information, consult the
systemd documentation:
https://www.freedesktop.org/software/systemd/man/systemd.unit.html

You can find the Lintian warning here:

https://lintian.debian.org/sources/uwsgi

In case this is a false positive, please add a Lintian override to
silence it and then close this bug.

Thanks! 

Message #18 received at 1039408@bugs.debian.org (full text, mbox, reply):

From: Alexandre Rossi <niol@zincube.net>

To: bluca@debian.org, 1039408@bugs.debian.org

Subject: Re: Bug#1039408: uwsgi: ships sysv-init script without systemd unit

Date: Thu, 31 Aug 2023 08:45:41 +0200

Hi,

> uwsgi has been flagged by Lintian as shipping a sysv-init script
> without a corresponding systemd unit file. The default init system in
> Debian is systemd, and so far this worked because a transitional
> sysv-init-to-unit generator was shipped by systemd. This is in the
> process of being deprecated and will be removed by the time Trixie
> ships, so the remaining packages that ship init scripts without
> systemd units will stop working.

[...]

> In case this is a false positive, please add a Lintian override to
> silence it and then close this bug.

My view on this is that the following template units provided by
uwsgi-core enable the initscript functionality.

    /lib/systemd/system/uwsgi-app@.service
    /lib/systemd/system/uwsgi-app@.socket

See full change[1] for documentation.

From the initscript documentation[2] and a quick look at the script,
it seems that it manages multiple uwsgi services from a
directory of configuration files. I think think if using systemd
that it is better managed using template units.

The above template lack supports for multiple type of configuration
files, assume INI, but this is easily fixable by overriding
the units.

uwsgi-emperor[3], from my understanding, does the same, and thus
does not need an initscript or systemd service unit.

My conclusion is that this is already fixed and that a lintian
override is relevant here, but I do not know if I'm missing something.

Thanks.

[1] https://salsa.debian.org/uwsgi-team/uwsgi/-/commit/bfb4ef445ad0168483638301090dc2d56e8e2278 
[2] https://salsa.debian.org/uwsgi-team/uwsgi/-/blob/bfb4ef445ad0168483638301090dc2d56e8e2278/debian/uwsgi.README.Debian
[3] https://uwsgi-docs.readthedocs.io/en/latest/Emperor.html

Message #23 received at 1039408@bugs.debian.org (full text, mbox, reply):

From: Luca Boccassi <bluca@debian.org>

To: Alexandre Rossi <niol@zincube.net>

Cc: 1039408@bugs.debian.org

Subject: Re: Bug#1039408: uwsgi: ships sysv-init script without systemd unit

Date: Thu, 31 Aug 2023 09:08:17 +0100

On Thu, 31 Aug 2023 at 07:45, Alexandre Rossi <niol@zincube.net> wrote:
>
> Hi,
>
> > uwsgi has been flagged by Lintian as shipping a sysv-init script
> > without a corresponding systemd unit file. The default init system in
> > Debian is systemd, and so far this worked because a transitional
> > sysv-init-to-unit generator was shipped by systemd. This is in the
> > process of being deprecated and will be removed by the time Trixie
> > ships, so the remaining packages that ship init scripts without
> > systemd units will stop working.
>
> [...]
>
> > In case this is a false positive, please add a Lintian override to
> > silence it and then close this bug.
>
> My view on this is that the following template units provided by
> uwsgi-core enable the initscript functionality.
>
>     /lib/systemd/system/uwsgi-app@.service
>     /lib/systemd/system/uwsgi-app@.socket
>
> See full change[1] for documentation.
>
> From the initscript documentation[2] and a quick look at the script,
> it seems that it manages multiple uwsgi services from a
> directory of configuration files. I think think if using systemd
> that it is better managed using template units.
>
> The above template lack supports for multiple type of configuration
> files, assume INI, but this is easily fixable by overriding
> the units.
>
> uwsgi-emperor[3], from my understanding, does the same, and thus
> does not need an initscript or systemd service unit.
>
> My conclusion is that this is already fixed and that a lintian
> override is relevant here, but I do not know if I'm missing something.

Thanks for looking into this, it definitely sounds like a false
positive - Lintian just does a 1:1 name matching I think. So please do
add a Lintian override for it and close this bug.

Message #24 received at 833067-close@bugs.debian.org (full text, mbox, reply):

From: Debian FTP Masters <ftpmaster@ftp-master.debian.org>

To: 833067-close@bugs.debian.org

Subject: Bug#833067: fixed in uwsgi 2.0.22-4

Date: Wed, 27 Sep 2023 16:45:01 +0000

Source: uwsgi
Source-Version: 2.0.22-4
Done: Jonas Smedegaard <dr@jones.dk>

We believe that the bug you reported is fixed in the latest version of
uwsgi, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 833067@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jonas Smedegaard <dr@jones.dk> (supplier of updated uwsgi package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Wed, 27 Sep 2023 17:18:53 +0200
Source: uwsgi
Architecture: source
Version: 2.0.22-4
Distribution: unstable
Urgency: medium
Maintainer: uWSGI packaging team <pkg-uwsgi-devel@lists.alioth.debian.org>
Changed-By: Jonas Smedegaard <dr@jones.dk>
Closes: 833067 1051752
Changes:
 uwsgi (2.0.22-4) unstable; urgency=medium
 .
   [ Alexandre Rossi ]
   * fix typo in d/uwsgi-core.README.Debian
   * update pcre2 patch from upstream merge request
   * add documentation link to systemd unit files
   * systemd socket unit: directly use /run instead of /var/run
   * add lintian override for missing uwsgi systemd service (Closes: #833067)
   * fix regular expressions for mangling debian/rules;
     really truly closes: bug#1051752
 .
   [ Jonas Smedegaard ]
   * update regular expressions for mangling debian/rules:
     + tighten and merge patterns
     + fix properly cover greenlet openjdk mono rados gccgo
       (not only glusterfs)
   * really exclude arch mipsel and add arch riscv64
     related to greenlet openjdk mono rados gccgo
Checksums-Sha1:
 62c55ff1e10cef1bce7b607f4a93da37c70920a6 6934 uwsgi_2.0.22-4.dsc
 63e06d0f9d1ce33962a232b1a6cdc38b0eeb467b 72764 uwsgi_2.0.22-4.debian.tar.xz
 247f3fcb009f9c1156cb7ede30da32603f67c315 37735 uwsgi_2.0.22-4_amd64.buildinfo
Checksums-Sha256:
 f62cb34d94e27757ba836dcca6e0e4d58acaeaaeac30a1a1340b44caab711e39 6934 uwsgi_2.0.22-4.dsc
 9edb0ec5bdd08d072ce105f76bff93e3668a51a2b385a34efaa428bf1571f17e 72764 uwsgi_2.0.22-4.debian.tar.xz
 41e49406d479ca8b56a0cef72c64030c679df048fa1d5252bcebfb21920330ee 37735 uwsgi_2.0.22-4_amd64.buildinfo
Files:
 c383e8bd24cc20ef09e9f6fe90baec0f 6934 httpd optional uwsgi_2.0.22-4.dsc
 9b7a09992b79735f955880a730525a90 72764 httpd optional uwsgi_2.0.22-4.debian.tar.xz
 76785ae1712ce771fe884a697a4aaba3 37735 httpd optional uwsgi_2.0.22-4_amd64.buildinfo

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEn+Ppw2aRpp/1PMaELHwxRsGgASEFAmUUS2AACgkQLHwxRsGg
ASFy4hAAl6S5w5rdY9ecQLcD/02unlWdzuWcTgCq/CpE+RGQsucuEzsWdBRlyhNo
238Jsw2G7oPiac+98FHPYbYQ17ilXqu24fG2kLqCLQqRs1N9e8HN7CJThLXyjecw
3/4Zz4vaOWiReJUYXvxvm2fe925dYgJ9x6/zVFTS1oUMKJTu/XpeOExzS/JeLs0A
mT9ndiOap8IqJVRMJ0whTz1cW5TRVClUG16vuJ7MM5g1cvsMWLHkAbtGrmql48bC
5MG6Op3Z2RGffkmrQtwtLFPnhNkEdnoXwa0QqG+BIcBOshVpUHeMzbJhACdqi22O
F8tcfTe2SseN3CFVZoJBN34ccxSGRqvALRaqn4Npg0k3Z8y4M7xWnjn4BwDGlhfQ
eSesBF1JWFJB/8VNeRLU2dyk1EzOw0aZaL+awZ24Ba9UE+OTdjQ6RaFKqPoOQSkL
zlRshYpk759Ls0hPYM4J62UxA3MQAJx/bZ2u9hbCWLvUmpzAbeAXBfCMTQmC4w4+
CBbOvxB7OVcGzstALPJ8fn9fgQWGEXrFf0lQ25FKObtszWukyWOp/jsEsP9GQyQI
4Fc9PDzWbKt4GVyIsFpZbQipjmn3qFvUYaOIQ7g07I9m41nkPHCqOFXMatygjlhf
9pjZ2T+IRCzK3PbzTHlR9555YM2rb+jJb+F1h1zd5xmRe7NLV+U=
=GTM8
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.