+
Skip to content

Conversation

jrmlt
Copy link
Contributor

@jrmlt jrmlt commented Sep 24, 2025

Which issue, if any, is this issue related to?

Closes #8776

Is there anything in the PR that needs further explanation?

Useful for nested at-rules inside language extension specific at-rules (such as @mixin in SCSS).

Copy link

changeset-bot bot commented Sep 24, 2025

⚠️ No Changeset found

Latest commit: eb6e3dc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jrmlt jrmlt changed the title Add ignoreAtRules to no-invalid-position-declaration Add ignoreAtRules: [] to no-invalid-position-declaration Sep 24, 2025
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. It's looking good!

I've requested some minor changes to the docs and tests to align with our conventions. We've many code examples and tests, and keeping them consistent helps users as they move through the READMEs of the rules.

jrmlt and others added 5 commits September 24, 2025 12:26
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
Co-authored-by: Richard Hallows <jeddy3@users.noreply.github.com>
@jrmlt
Copy link
Contributor Author

jrmlt commented Sep 24, 2025

Thanks for the quick review 👌

Copy link
Contributor

github-actions bot commented Sep 24, 2025

This PR is packaged and the instant preview is available (eb6e3dc). View the demo website.

Install it locally:

npm i -D https://pkg.pr.new/stylelint@eb6e3dc

Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the requested changes and patching up the tests.

LGTM.

Demo.

@jrmlt
Copy link
Contributor Author

jrmlt commented Sep 24, 2025

Not sure why I'm getting Property no-invalid-position-declaration is not allowed. in the demo.

But I can see it working just fine in local using @4c27d85

@jeddy3
Copy link
Member

jeddy3 commented Sep 24, 2025

The schema for the demo is outdated. I've opened stylelint/stylelint-demo#489 to update it.

Copy link
Member

@ryo-manba ryo-manba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Copy link
Member

@ybiquitous ybiquitous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. 👍🏼

My trivial suggestion is just optional.

jrmlt and others added 2 commits September 24, 2025 15:12
@jeddy3 jeddy3 merged commit b478202 into stylelint:main Sep 25, 2025
17 checks passed
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 3, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.24.0 | 16.25.0 |


## [v16.25.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16250---2025-10-03)

It adds 3 new features, including experimental support for bulk suppressions. It's also our first [immutable release](https://github.blog/changelog/2025-08-26-releases-now-support-immutability-in-public-preview/), with the package published to npm using [trusted publishing](https://github.blog/changelog/2025-07-31-npm-trusted-publishing-with-oidc-is-generally-available/) and our dependencies updated on a [cool down](https://github.blog/changelog/2025-07-01-dependabot-supports-configuration-of-a-minimum-package-age/) for improved supply chain security.

- Added: support for bulk suppressions ([#8564](stylelint/stylelint#8564)) ([@ryo-manba](https://github.com/ryo-manba)).
- Added: `ignoreAtRules: []` to `no-invalid-position-declaration` ([#8781](stylelint/stylelint#8781)) ([@jrmlt](https://github.com/jrmlt)).
- Added: rule name to custom messages ([#8774](stylelint/stylelint#8774)) ([@jhae-de](https://github.com/jhae-de)).
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 3, 2025
| datasource | package   | from    | to      |
| ---------- | --------- | ------- | ------- |
| npm        | stylelint | 16.24.0 | 16.25.0 |


## [v16.25.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16250---2025-10-03)

It adds 3 new features, including experimental support for bulk suppressions. It's also our first [immutable release](https://github.blog/changelog/2025-08-26-releases-now-support-immutability-in-public-preview/), with the package published to npm using [trusted publishing](https://github.blog/changelog/2025-07-31-npm-trusted-publishing-with-oidc-is-generally-available/) and our dependencies updated on a [cool down](https://github.blog/changelog/2025-07-01-dependabot-supports-configuration-of-a-minimum-package-age/) for improved supply chain security.

- Added: support for bulk suppressions ([#8564](stylelint/stylelint#8564)) ([@ryo-manba](https://github.com/ryo-manba)).
- Added: `ignoreAtRules: []` to `no-invalid-position-declaration` ([#8781](stylelint/stylelint#8781)) ([@jrmlt](https://github.com/jrmlt)).
- Added: rule name to custom messages ([#8774](stylelint/stylelint#8774)) ([@jhae-de](https://github.com/jhae-de)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add ignoreAtRules: [] to no-invalid-position-declaration
4 participants
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载