feat: Add --ext CLI option
#19405
Merged
feat: Add --ext CLI option
#19405
+197
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
commented
Feb 5, 2025
| @@ -218,17 +218,17 @@ describe("cli", () => { | |||
| it(`should use it when an eslint.config.js is present and useFlatConfig is true:${configType}`, async () => { | |||
| process.cwd = getFixturePath; | |||
|
|
|||
| const exitCode = await cli.execute(`--no-ignore --ext .js ${getFixturePath("files")}`, null, useFlatConfig); | |||
| const exitCode = await cli.execute(`--no-ignore --env es2024 ${getFixturePath("files")}`, null, useFlatConfig); | |||
There was a problem hiding this comment.
This test, and a couple of tests below it, need an eslintrc-only CLI option.
nzakas
previously approved these changes
Feb 5, 2025
fasttime
reviewed
Feb 7, 2025
Comment on lines
+195
to
+200
| if (ext) { | ||
| overrideConfig.push({ | ||
| files: ext.map(extension => `**/*${extension.startsWith(".") ? "" : "."}${extension}`) | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
When I run this command on a zsh terminal:
node bin/eslint.js --ext ""I get an error like:
Oops! Something went wrong! :(
ESLint: 9.19.0
TypeError: Config (unnamed): Key "files": Expected value to be a non-empty array at user-defined index 34.
at wrapConfigErrorWithDetails (.../lib/config/flat-config-array.js:64:12)
at .../lib/config/flat-config-array.js:145:27
at async ConfigLoader.calculateConfigArray (.../lib/config/config-loader.js:557:9)
at async #calculateConfigArray (.../lib/config/config-loader.js:633:29)
at async entryFilter (.../lib/eslint/eslint-helpers.js:281:33)
at async NodeHfs.<anonymous> (file://.../node_modules/@humanfs/core/src/hfs.js:574:24)
at async NodeHfs.walk (file://.../node_modules/@humanfs/core/src/hfs.js:614:3)
at async globSearch (.../lib/eslint/eslint-helpers.js:323:26)
at async Promise.allSettled (index 0)
at async globMultiSearch (.../lib/eslint/eslint-helpers.js:408:21)It seems it would be better to catch this error in the CLI to provide a clear error message?
There was a problem hiding this comment.
Good catch! We probably want to validate that ext is not an empty string when the CLI options are validated.
There was a problem hiding this comment.
It seems it would be better to catch this error in the CLI to provide a clear error message?
Good idea! Yeah, it's not clear that --ext relates to Key "files". I'll update this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[x] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #19361
What changes did you make? (Give an overview)
Added new
--extCLI option as per #19361 (comment).Is there anything you'd like reviewers to focus on?
This is a CLI-only option. Integrations can enable additional file extensions in
baseConfigoroverrideConfig.