feat: new audit: anonymous-definition #937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: * GitHub UI being impacted by unnamed Workflows make severity feel higher for that than jobs. That said, since it is not a security problem, I felt like "Low" was appropriate. Curious thoughts on this. * I left out 'ReusableWorkflowCallJob' since as far as I could tell, they did not have any naming capabilities Closes: zizmorcore#795
|
Thanks @andrewpollack! I'll give this a review later today. |
woodruffw
approved these changes
Jun 12, 2025
There was a problem hiding this comment.
Thanks @andrewpollack, this looks really great! Just some small feedback items.
Apart from that, this PR needs two things for merge-readiness:
- An update to
audits.mdwith a new section documenting this audit; the other sections should be a good reference 🙂 - An update to
release-notes.mdunder the "New Features" category, like with previous release notes for new audits
|
Thank you for the review, this is great! I'll push updates later tonight |
|
Added docs as part of 075cea0 |
Signed-off-by: William Woodruff <william@yossarian.net>
woodruffw
approved these changes
Jun 14, 2025
|
LGTM, thanks a ton @andrewpollack! |
Signed-off-by: William Woodruff <william@yossarian.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
Closes: #795