+
Skip to content

fix: remove spurious panic in env handling #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025
Merged

fix: remove spurious panic in env handling #887

merged 5 commits into from
Jun 2, 2025

Conversation

woodruffw
Copy link
Member

This fixes #883 by removing the panic! case entirely -- it's not actually needed, since uses: steps can contain env: blocks.

Fixes #883.

Fixes #883.

Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw self-assigned this Jun 2, 2025
@woodruffw woodruffw added the bugfix Fixes a known bug label Jun 2, 2025
woodruffw added 4 commits June 2, 2025 13:57
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
Signed-off-by: William Woodruff <william@yossarian.net>
@woodruffw woodruffw merged commit a4a657f into main Jun 2, 2025
8 checks passed
@woodruffw woodruffw deleted the ww/issue-883 branch June 2, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a known bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Crash Report: "API misuse: can't call env_is_static on a uses: step"
1 participant
点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载