Handle ChainStateBuilder errors, avoid unwraps #471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69fbcca to
87b634a
Compare
crates/floresta-chain/src/pruned_utreexo/chain_state_builder.rs
Outdated
Show resolved
Hide resolved
crates/floresta-chain/src/pruned_utreexo/chain_state_builder.rs
Outdated
Show resolved
Hide resolved
crates/floresta-chain/src/pruned_utreexo/chain_state_builder.rs
Outdated
Show resolved
Hide resolved
crates/floresta-chain/src/pruned_utreexo/chain_state_builder.rs
Outdated
Show resolved
Hide resolved
4ff7f6b to
f8a10f0
Compare
Previously we were using `unwrap` for things like chainstore operations and `Option` values unwrapping. I have replaced all unwraps in the file with proper error handling. Added the new `IncompleteTip` and `Database` error variants. Polished a bit the comments. Also instead of implementing `From` ChainStateBuilder for Chainstate I implement `TryFrom` (it's fallible, failing if the chainstore and chain params are not set).
f8a10f0 to
f648c65
Compare
|
Addressed the helpful comments from @Davidson-Souza |
luisschwab
pushed a commit
to luisschwab/Floresta
that referenced
this pull request
May 7, 2025
Previously we were using `unwrap` for things like chainstore operations and `Option` values unwrapping. I have replaced all unwraps in the file with proper error handling. Added the new `IncompleteTip` and `Database` error variants. Polished a bit the comments. Also instead of implementing `From` ChainStateBuilder for Chainstate I implement `TryFrom` (it's fallible, failing if the chainstore and chain params are not set).
luisschwab
pushed a commit
to luisschwab/Floresta
that referenced
this pull request
May 8, 2025
Previously we were using `unwrap` for things like chainstore operations and `Option` values unwrapping. I have replaced all unwraps in the file with proper error handling. Added the new `IncompleteTip` and `Database` error variants. Polished a bit the comments. Also instead of implementing `From` ChainStateBuilder for Chainstate I implement `TryFrom` (it's fallible, failing if the chainstore and chain params are not set).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Which crates are being modified?
Description
Relates to #463. This is a first step on hardening error handling.
Previously we were using
unwrapfor things like chainstore operations andOptionvalues unwrapping in theChainStateBuildermethods.I have replaced all unwraps in the file with proper error handling. Added the new
IncompleteTipandDatabaseerror variants. Polished a bit the comments.Also instead of implementing
FromChainStateBuilder for Chainstate I implementTryFrom(it's fallible, failing if the chainstore and chain params are not set).