-
Notifications
You must be signed in to change notification settings - Fork 62
Docs chain state builder #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs chain state builder #430
Conversation
crates/floresta-chain/src/pruned_utreexo/chain_state_builder.rs
Outdated
Show resolved
Hide resolved
bf12cc1
to
1b154bb
Compare
ack 1b154bb |
1b154bb
to
709420a
Compare
I believe I addressed each suggestion. If I missed anything just let me know. As #433 , this is also being prevented to build doc as the |
Oh, shoot! (We should run cargo docs on our CI too 🤔) |
Well, it was working about 10 days ago as I was able to create the docs. I ran |
This is the log am I getting:
I know @luisschwab also got this same error, is anyone else getting it when running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 709420a
The error seems unrelated, I'm having the exact same problem with master
I was... maybe we could raise this for the bitcoin_hashes folks ? |
I tried to build the Bitcoin Rust docs to see if anything would happen. It didn't. It appears to be a problem when it's on dependencies. |
What is the purpose of this pull request?
Which crates are being modified?
Description
Added missing docs for the Floresta Chain, specifically the Chain State Builder.
Notes to the reviewers
Most of the struct, the enum and the methods are self explaining. I added docs to keep it nice on cargo doc. Addresses #376
Checklist
just lint
cargo test