Added --gen-selfsigned-cert flag #425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28e3141 to
28b5293
Compare
|
Sorry for holding you on this, but I think this new option deserves a mention on README. |
🫡 No need to sorry, it's my fault to not did it yet. |
|
I like the changes, but this is changing way more than just adding ssl stuff on readme 😂 |
Maybe more simple than explaining the consequences and put it on another place after #429? |
Please leave the section about ssl and remove the other changes to README. |
Sure, sorry for other removes. I didn't had attention that was a neo-vim linter stuff. |
|
@qlrd needs rebase |
Fix vinteumorg#423 This flag, when passed to florestad, will create a ssl folder in <data-dir> and <data-dir>/ssl/key.pem and a self-signed<data-dir>/ssl/cert.pem. This self-signed certificate can be a option to users that do not have certificates with a trusted chain. It's important to note that the private-key isn't encrypted. More specifically, this commit add: * a flag --gen-selfsigned-cert on CLI; * some enums elements on error.rs; * a generate_selfsigned_certificate on florestad.rs; * a new step on florestad::start method before creating the TLS-enabledelectrum server.
The readme give some instructions about node: * with a non-TLS enabled electrum; * with a TLS enabled electrum given a PKCS#8 private-key / certificate; * with a TLS enabled electrum with self-signed PKCS#8 private-key / certificate;
lucad70
added a commit
to lucad70/Floresta
that referenced
this pull request
Apr 11, 2025
- Renamed files build_mac_os.md and build_unix.md - Added instruction to generate SSL certificates vinteumorg#425
lucad70
added a commit
to lucad70/Floresta
that referenced
this pull request
Apr 11, 2025
This commit changes the way that the README is structured. It used to be everything under one file but now it is separated in different files in a new folder. - Renamed files build_mac_os.md and build_unix.md - Added instruction to generate SSL certificates vinteumorg#425 - Cleaned README.md - Applied NITs - Rephrased instructions - Added fuzzing target suggestion
lucad70
added a commit
to lucad70/Floresta
that referenced
this pull request
Apr 11, 2025
This commit changes the way that the README is structured. It used to be everything under one file but now it is separated in different files in a new folder. - Renamed files build_mac_os.md and build_unix.md - Added instruction to generate SSL certificates vinteumorg#425 - Cleaned README.md - Applied NITs - Rephrased instructions - Added fuzzing target suggestion
lucad70
added a commit
to lucad70/Floresta
that referenced
this pull request
Apr 14, 2025
This commit changes the way that the README is structured. It used to be everything under one file but now it is separated in different files in a new folder. - Renamed files build_mac_os.md and build_unix.md - Added instruction to generate SSL certificates vinteumorg#425 - Cleaned README.md - Applied NITs - Rephrased instructions - Added fuzzing target suggestion Added link to setting-functional-tests-binaries Added sugestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #423
What is the purpose of this pull request?
Which crates are being modified?
Description
This flag, when passed to florestad, will create a ssl folder in
<data-dir>and<data-dir>/ssl/key.pemand a self-signed<data-dir>/ssl/cert.pem. This self-signed certificate can be a option to those users that do not have certificates with a trusted chain. It's import to note that the private-key isn't encrypted.More specifically, this commit add:
a flag --gen-selfsigned-cert on CLI;
some enums elements on error.rs
a generate_selfsigned_certificate on florestad.rs;
a new step on florestad::start method before creating the TLS-enabled electrum server.
Notes to the reviewers
This PR is a followup of #421
Checklist
just lintcargo test