This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Use NIO's primitive functions for flatMap and its siblings. #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a stack overflow in case of many nested flat maps (see the tests). Plus, it speeds up `testFlatMapPerformance` by about 20%.
|
@tanner0101 would you mind reviewing this? |
|
Thanks @MrLotU! Could anyone with merge rights merge this? |
|
@MrMage There are a few issues with the tests. I'm currently working on resolving those and will merge & tag this once done 😄 |
MrLotU
approved these changes
Nov 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes a stack overflow in case of many nested flat maps (see the tests). Plus, it speeds up
testFlatMapPerformanceby about 20%:Thanks to @weissi for finding the culprit and suggesting a fix as well as tests.