This repository was archived by the owner on Jun 27, 2023. It is now read-only.
Use NIO's whenAll for Collection.flatten now.
#203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Benchmark for TemplateKit's |
|
Impact on Leaf's |
MrLotU
approved these changes
Apr 12, 2019
|
CC: @tanner0101 |
|
Friendly ping @tanner0101 :-) |
tanner0101
approved these changes
Apr 23, 2019
|
Hey @MrMage, you just merged a pull request, have a coin! You now have 25 coins. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark results compared to Core 3.8.1:
I.e. another 3x improvement, as promised. (cc @weissi)
We could also delete
FutureTypeentirely now. Technically, this is part of Core's public API, but as far as I can tell, its only purpose was to allow implementingflatten, which now seems to be possible without that workaround.