+
Skip to content

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Jan 9, 2025

What type of PR is this?

What does this do?

  • New Features

    • Added support for CVM (Confidential Virtual Machine) service with gRPC streaming capabilities
    • Introduced new methods for initializing and stopping computations
    • Enhanced event logging and metrics tracking for computation lifecycle
  • Improvements

    • Refactored event handling to use message queues instead of direct connections
    • Updated algorithm execution to support better process management
    • Simplified configuration management using environment variables
  • Breaking Changes

    • Removed AgentConfig from computation configurations
    • Changed gRPC client and service interfaces
    • Modified event sending mechanism to include computation ID
  • Bug Fixes

    • Improved error handling in algorithm execution
    • Enhanced logging and metrics instrumentation

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 58.50340% with 183 lines in your changes missing coverage. Please review.

Project coverage is 65.41%. Comparing base (59b8057) to head (14f4841).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
agent/cvms/api/grpc/client.go 73.37% 34 Missing and 11 partials ⚠️
agent/cvms/server/cvm.go 0.00% 44 Missing ⚠️
agent/service.go 43.63% 28 Missing and 3 partials ⚠️
agent/algorithm/python/python.go 27.77% 11 Missing and 2 partials ⚠️
agent/algorithm/binary/binary.go 33.33% 11 Missing and 1 partial ⚠️
agent/algorithm/wasm/wasm.go 33.33% 12 Missing ⚠️
agent/cvms/api/grpc/server.go 85.71% 8 Missing and 2 partials ⚠️
pkg/clients/grpc/cvm/cvm.go 0.00% 6 Missing ⚠️
internal/logger/protohandler.go 75.00% 4 Missing and 1 partial ⚠️
agent/algorithm/docker/docker.go 33.33% 4 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   66.31%   65.41%   -0.91%     
==========================================
  Files          53       57       +4     
  Lines        4391     4756     +365     
==========================================
+ Hits         2912     3111     +199     
- Misses       1207     1360     +153     
- Partials      272      285      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina requested a review from smithjilks January 13, 2025 13:25
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
}
}

type runRequestManager struct {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to avoid implementing this chunk manager (proto/grpc lib or 3rd-party lib)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proto/grpc does not support it, I have not found a third party lib at the moment, I just looked at the simple implementation for out use case

…Client to CVMSClient

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
… tests

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
…ice tests

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@dborovcanin dborovcanin merged commit ecad651 into ultravioletrs:main Jan 17, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Design architecture for Agent direct connection to cloud

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载