NOISSUE - Add launch TCB info to VM info #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
==========================================
- Coverage 66.40% 66.31% -0.09%
==========================================
Files 53 53
Lines 4352 4391 +39
==========================================
+ Hits 2890 2912 +22
- Misses 1192 1207 +15
- Partials 270 272 +2 ☔ View full report in Codecov by Sentry. |
SammyOina
requested changes
Dec 11, 2024
manager/service.go
Outdated
| } | ||
| ms.mu.Unlock() | ||
|
|
||
| cmd := exec.Command("sudo", fmt.Sprintf("%s/attestation_policy", ms.attestationPolicyBinaryPath), "--policy", "196608") |
There was a problem hiding this comment.
run conditionally only for when qemu config is set for SEV or SEV_SNP
SammyOina
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a update to the VM information that is being saved. It saves the launch TCB for the launched VM so it can be later used in the attestation verification and validation process. The AR contains the field
LAUNCH_TCBwhich contains the TCB value when the VM was launched.What does this do?
This PR adds the launch TCB value to the new structure
VMInfo. The new structure hold information on the launched VM. The launch TCB is later used in the verification and validation process of the attestation report. It validates the launch TCB field of the attestation report.Which issue(s) does this PR fix/relate to?
No issue.
Have you included tests for your changes?
The tests are the same as before.
Did you document any new/modified feature?
This feature is part of the attestation validation and verification process.
Notes