+
Skip to content

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Nov 22, 2024

What type of PR is this?

this is a bug fix of possible race conditions while running a computation

What does this do?

  • New Features

    • Improved handling of configuration updates for better clarity and isolation.
    • Enhanced thread safety during state transitions of the VM.
  • Bug Fixes

    • Adjusted locking mechanisms to prevent race conditions during VM state modifications.
  • Refactor

    • Modified logic for assigning the measurement variable in the attestation policy.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.49%. Comparing base (77d99d4) to head (0cd441b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/attestation_policy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   65.43%   65.49%   +0.05%     
==========================================
  Files          53       53              
  Lines        4320     4327       +7     
==========================================
+ Hits         2827     2834       +7     
  Misses       1218     1218              
  Partials      275      275              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina changed the title fix panic NOISSUE - Prevent race conditions on manager Nov 22, 2024
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit d70bf05 into ultravioletrs:main Nov 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载