+
Skip to content

Conversation

SammyOina
Copy link
Contributor

What type of PR is this?

What does this do?

renames backend info to attestation policy

Which issue(s) does this PR fix/relate to?

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 77.55102% with 11 lines in your changes missing coverage. Please review.

Project coverage is 65.43%. Comparing base (5a22ac2) to head (00f5a98).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
manager/attestation_policy.go 50.00% 3 Missing and 1 partial ⚠️
cli/attestation_policy.go 75.00% 2 Missing and 1 partial ⚠️
pkg/clients/grpc/connect.go 66.66% 2 Missing ⚠️
manager/api/grpc/client.go 90.00% 1 Missing ⚠️
pkg/attestation/quoteprovider/sev.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #314   +/-   ##
=======================================
  Coverage   65.42%   65.43%           
=======================================
  Files          53       53           
  Lines        4318     4319    +1     
=======================================
+ Hits         2825     2826    +1     
  Misses       1218     1218           
  Partials      275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina requested a review from drasko November 19, 2024 15:31
@drasko
Copy link
Contributor

drasko commented Nov 19, 2024

@danko-miladinovic please review this one.

Is maybe Attestation Report, or Attestation Measurement better naming for this? This is why I asked for IETF RATS terminology, to better understand if this is the best term, as is not self-explanatory to e as Backend Info was.

@SammyOina SammyOina added this to the Release V1 milestone Nov 21, 2024
@danko-miladinovic
Copy link
Contributor

The name is fine. The attestation policy json file (previously backend info) is used for verification and validation of attestation request. It contains information that are used by the go-sev-guest library to verify/validate the report. In RATS terminology the attestation policy would be equivalent to Appraisal Policy for Evidence or Appraisal Policy. The Attestation Policy name is fine because besides the values that it holds (measurement, minimum TCB, and so on) it also holds the values needed for the CLI to fetch certificates from the AMD KDS.

Copy link
Contributor

@danko-miladinovic danko-miladinovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dborovcanin dborovcanin merged commit 760c9bb into ultravioletrs:main Nov 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载