+
Skip to content

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Nov 5, 2024

What type of PR is this?

What does this do?

  • New Features

    • Improved logic for assigning unique GuestCIDs to VMs, enhancing conflict prevention.
    • Enhanced error handling for algorithm and dataset hashes during VM provisioning.
  • Bug Fixes

    • Refined error handling for port allocation to provide clearer context in case of failure.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e372cfc). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/service.go 58.33% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage        ?   56.61%           
=======================================
  Files           ?       57           
  Lines           ?     4596           
  Branches        ?        0           
=======================================
  Hits            ?     2602           
  Misses          ?     1719           
  Partials        ?      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 0380b23 into ultravioletrs:main Nov 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载