+
Skip to content

NOISSUE - Improve file streaming #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Nov 7, 2024
Merged

NOISSUE - Improve file streaming #295

merged 17 commits into from
Nov 7, 2024

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Nov 1, 2024 •
edited
Loading

What type of PR is this?

What does this do?

  • New Features

    • Enhanced file handling for algorithms and datasets, allowing direct use of file pointers instead of byte buffers.
    • Users can now specify custom filenames for result files during retrieval.

  • Bug Fixes

    • Updated tests to reflect changes in method signatures and ensure consistent error handling.

  • Refactor

    • Streamlined the handling of file inputs across multiple commands and tests, improving efficiency and clarity.

  • Documentation

    • Updated example usages in commands to reflect new optional parameters and functionalities.

Which issue(s) does this PR fix/relate to?

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@drasko
Copy link
Contributor

drasko commented Nov 1, 2024 •
edited
Loading

Is this a draft? If not - please add description and fix the title.

@SammyOina SammyOina changed the title improve file streaming NOISSUE - Improve file streaming Nov 4, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.62500% with 63 lines in your changes missing coverage. Please review.

Project coverage is 61.96%. Comparing base (01a619f) to head (e5aace5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/zip.go 59.09% 12 Missing and 6 partials ⚠️
cli/attestation.go 31.81% 12 Missing and 3 partials ⚠️
pkg/progressbar/progressbar.go 73.58% 10 Missing and 4 partials ⚠️
pkg/sdk/agent.go 53.33% 7 Missing ⚠️
cli/result.go 66.66% 3 Missing and 1 partial ⚠️
cli/datasets.go 57.14% 3 Missing ⚠️
cli/algorithms.go 71.42% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #295      +/-   ##
==========================================
+ Coverage   57.69%   61.96%   +4.26%     
==========================================
  Files          57       54       -3     
  Lines        4598     4262     -336     
==========================================
- Hits         2653     2641      -12     
+ Misses       1679     1342     -337     
- Partials      266      279      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SammyOina
improve file streaming
ac40443 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
error check
b3ebc4c 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
empty line
64f6cd8 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix tests
15af4b1 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
send buffer test
6bada83 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix test cases
f4c2c27 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
stream data and attestation
3e5a1d0 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fumpt
1759d63 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix test
7e1ff00 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
mocks
1064a10 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
value check
ee17af5 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
more value checks
96fcc73 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
add test cases
98d94e0 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fumpt
7b98bfd 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix tests
23d607f 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
all files
48c4a7a 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix lint
e5aace5 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@dborovcanin dborovcanin merged commit 46b9420 into ultravioletrs:main Nov 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dborovcanin dborovcanin dborovcanin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SammyOina @drasko @dborovcanin
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载