+
Skip to content

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Oct 28, 2024

What type of PR is this?

What does this do?

  • New Features

    • Enhanced the Attestation method to support streaming responses, allowing multiple responses to be sent back to clients.
    • Introduced new methods in the ProgressBar for handling download operations, providing better visual feedback during downloads.
  • Bug Fixes

    • Improved error handling in the Result and Attestation methods for better reliability.
  • Documentation

    • Updated method signatures and descriptions to reflect changes in streaming functionality and progress reporting.
  • Tests

    • Added a mock server for testing the attestation functionality, enhancing test coverage and reliability.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

image

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 54.96183% with 59 lines in your changes missing coverage. Please review.

Project coverage is 42.71%. Comparing base (3ca3d48) to head (ba5cfb9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
agent/agent_grpc.pb.go 0.00% 25 Missing ⚠️
pkg/sdk/agent.go 61.11% 9 Missing and 5 partials ⚠️
agent/api/grpc/server.go 51.85% 9 Missing and 4 partials ⚠️
pkg/progressbar/progressbar.go 83.72% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #290      +/-   ##
==========================================
+ Coverage   42.49%   42.71%   +0.22%     
==========================================
  Files          77       77              
  Lines        6265     6347      +82     
==========================================
+ Hits         2662     2711      +49     
- Misses       3261     3282      +21     
- Partials      342      354      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 6043ad1 into ultravioletrs:main Oct 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Add progress bar for attestation and result download

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载