+
Skip to content

COCOS-278 - Abstract state machine #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2024
Merged

COCOS-278 - Abstract state machine #280

merged 5 commits into from
Oct 9, 2024

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Oct 9, 2024 •
edited
Loading

What type of PR is this?

What does this do?

  • New Features

    • Introduced enhanced state management for the agent service, allowing for more dynamic state transitions and improved logging capabilities.
    • Added unique file naming for computation result files, enhancing user feedback on saved files.

  • Bug Fixes

    • Improved handling of multiple executions in tests to ensure correct file generation and retrieval.

  • Tests

    • Expanded test coverage for state management and result file handling, including new tests for unique file path generation.

  • Documentation

    • Updated documentation to reflect new functionalities and changes in the state machine and result handling logic.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@SammyOina
abstract state machine
cbd34f3 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
perpetual results consumption
97ea857 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
async action
5852b11 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix failing tests
85e509f 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix failing test
633ebd8 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.78049% with 43 lines in your changes missing coverage. Please review.

Project coverage is 38.35%. Comparing base (fb0fbae) to head (633ebd8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
agent/statemachine/mocks/state.go 40.62% 13 Missing and 6 partials ⚠️
agent/service.go 76.56% 11 Missing and 4 partials ⚠️
cli/result.go 68.75% 3 Missing and 2 partials ⚠️
agent/agentevent_string.go 50.00% 1 Missing and 1 partial ⚠️
agent/agentstate_string.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   38.27%   38.35%   +0.07%     
==========================================
  Files          78       80       +2     
  Lines        5366     5420      +54     
==========================================
+ Hits         2054     2079      +25     
- Misses       2988     3006      +18     
- Partials      324      335      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

drasko
drasko approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit db7f3c7 into ultravioletrs:main Oct 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drasko drasko drasko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Add functionality to store results in subdirectories with unique IDs in the results directory

2 participants

@SammyOina @drasko
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载