+
Skip to content

COCOS-253 - Improve CLI error handling #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 8, 2024
Merged

COCOS-253 - Improve CLI error handling #277

merged 6 commits into from
Oct 8, 2024

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Oct 8, 2024 •
edited
Loading

What type of PR is this?

What does this do?

  • New Features

    • Enhanced command-line interface (CLI) output for various commands with user-friendly messages.
    • Introduced a global Verbose flag for configurable command output.

  • Bug Fixes

    • Improved error handling across multiple commands, ensuring graceful exits without abrupt terminations.

  • Documentation

    • Updated command usage messages for better clarity and usability.

  • Chores

    • Removed logging functionality in favor of direct command output, streamlining the codebase.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@codecov Codecov
Copy link

codecov bot commented Oct 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.93939% with 109 lines in your changes missing coverage. Please review.

Project coverage is 38.31%. Comparing base (7ef2567) to head (a9167ed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/cli/main.go 0.00% 34 Missing ⚠️
cli/attestation.go 0.00% 26 Missing ⚠️
cli/keys.go 10.34% 23 Missing and 3 partials ⚠️
cli/cache.go 0.00% 12 Missing ⚠️
cli/datasets.go 68.42% 6 Missing ⚠️
cli/backend_info.go 0.00% 4 Missing ⚠️
cli/algorithms.go 90.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   38.31%   38.31%           
=======================================
  Files          77       78    +1     
  Lines        5322     5366   +44     
=======================================
+ Hits         2039     2056   +17     
- Misses       2963     2987   +24     
- Partials      320      323    +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SammyOina SammyOina changed the title Cocos 253 COCOS-253 - Improve CLI error handling Oct 8, 2024
drasko
drasko approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SammyOina
decode errors
14b6c2d 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
standardise error formatting
87a3fc2 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
fix failing tests
adad0e5 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
add errors tests
977d870 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
pass lint
efae8d7 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina
add test cases
a9167ed 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@drasko drasko merged commit fb0fbae into ultravioletrs:main Oct 8, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drasko drasko drasko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature: Show more descriptive error messages on cli

2 participants

@SammyOina @drasko
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载