+
Skip to content

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Oct 3, 2024

What type of PR is this?

What does this do?

  • New Features

    • Introduced a new TEE field in the agent configuration to enhance security.
    • Added a manifest verification process to ensure the integrity of agent configurations.
    • Enhanced backend information fetching by requiring a computation ID for more accurate data retrieval.
    • New GetConfig method added to the VM interface and mock for improved access to configuration details.
  • Bug Fixes

    • Improved error handling in backend information methods to ensure correct VM configurations are used.
  • Documentation

    • Updated method signatures to reflect new parameters and functionality for clarity.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 45.76271% with 64 lines in your changes missing coverage. Please review.

Project coverage is 43.40%. Comparing base (bb903c0) to head (3b138e1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/agent/main.go 34.37% 21 Missing ⚠️
manager/vm/mocks/state_machine.go 40.00% 9 Missing and 6 partials ⚠️
manager/api/logging.go 0.00% 6 Missing ⚠️
manager/mocks/service.go 25.00% 3 Missing and 3 partials ⚠️
manager/vm/mocks/vm.go 54.54% 2 Missing and 3 partials ⚠️
agent/statemachine/mocks/state.go 57.14% 2 Missing and 1 partial ⚠️
manager/tracing/tracing.go 0.00% 3 Missing ⚠️
manager/api/metrics.go 0.00% 2 Missing ⚠️
manager/backend_info.go 87.50% 2 Missing ⚠️
manager/api/grpc/client.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #275      +/-   ##
==========================================
- Coverage   43.94%   43.40%   -0.54%     
==========================================
  Files          78       77       -1     
  Lines        5307     5234      -73     
==========================================
- Hits         2332     2272      -60     
- Misses       2605     2620      +15     
+ Partials      370      342      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dborovcanin
Copy link
Contributor

@SammyOina What's the status of this PR?

@SammyOina SammyOina changed the title NOISSUE - host data verification NOISSUE - Host data verification Oct 11, 2024
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina requested a review from dborovcanin October 11, 2024 15:08
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@dborovcanin dborovcanin merged commit 184617d into ultravioletrs:main Oct 14, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载