+
Skip to content

NOISSUE - Add manager tests #273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2024
Merged

NOISSUE - Add manager tests #273

merged 1 commit into from
Oct 8, 2024

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Oct 2, 2024 •
edited
Loading

What type of PR is this?

What does this do?

  • New Features

    • Introduced new unit tests for managerService and ManagerClient functionalities, enhancing test coverage.
    • Added tests for QEMU configuration and persistence methods, ensuring correct command-line argument generation and VM state management.

  • Bug Fixes

    • Improved handling of context cancellation in gRPC server methods to enhance robustness.

  • Documentation

    • Added code generation directive for creating mock implementations of the Service interface.

  • Refactor

    • Enhanced existing test functions for better error handling and coverage across various scenarios.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@SammyOina
add manager tests
6773f6d 
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina changed the title add manager tests NOISSUE - Add manager tests Oct 2, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 44.11765% with 38 lines in your changes missing coverage. Please review.

Project coverage is 26.32%. Comparing base (3d9fde3) to head (6773f6d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
manager/mocks/service.go 38.46% 17 Missing and 15 partials ⚠️
manager/api/grpc/server.go 62.50% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   18.83%   26.32%   +7.48%     
==========================================
  Files          76       77       +1     
  Lines        5213     5273      +60     
==========================================
+ Hits          982     1388     +406     
+ Misses       4057     3656     -401     
- Partials      174      229      +55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

drasko
drasko reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drasko drasko merged commit 5e01ecd into ultravioletrs:main Oct 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drasko drasko drasko left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SammyOina @drasko
点击 这是indexloc提供的php浏览器服务，不要输入任何密码和下载