+
Skip to content

Conversation

SammyOina
Copy link
Contributor

@SammyOina SammyOina commented Sep 26, 2024

What type of PR is this?

What does this do?

  • Bug Fixes

    • Improved test reliability by adding delays in state machine transition tests to ensure asynchronous operations complete before assertions.
  • Chores

    • Updated service identifier for clarity, changing svcName from "manager_test_server" to "computations_test_server".
    • Added a new target for test coverage in the Makefile, enhancing test reporting capabilities.
  • Documentation

    • Introduced a coverage badge in the README.md to visually indicate the project's test coverage status.

Which issue(s) does this PR fix/relate to?

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@SammyOina SammyOina changed the title add sleep to prevent test failing NOISSUE - Improve reliability of state machine test Sep 26, 2024
@SammyOina SammyOina self-assigned this Sep 26, 2024
Copy link
Contributor

@dborovcanin dborovcanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use Codecov actions for this, something like:

name: Run tests and upload coverage

on: 
  push

jobs:
  test:
    name: Run tests and collect coverage
    runs-on: ubuntu-latest
    steps:
      - name: Checkout
        uses: actions/checkout@v4
        with:
          fetch-depth: 0

      - name: Set up Go
        uses: actions/setup-go@v5

      - name: Install dependencies
        run: go mod download

      - name: Run tests
        run: go test -coverprofile=coverage.txt

      - name: Upload results to Codecov
        uses: codecov/codecov-action@v4
        with:
          token: ${{ secrets.CODECOV_TOKEN }}

@dborovcanin
Copy link
Contributor

dborovcanin commented Sep 26, 2024

I have set Codecove and token, and this is the badge URL for Markdown: [![codecov](https://codecov.io/gh/ultravioletrs/cocos/graph/badge.svg?token=HX01LR01K9)](https://codecov.io/gh/ultravioletrs/cocos)

Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
@dborovcanin dborovcanin merged commit c69dcd0 into ultravioletrs:main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载