+
Skip to content

Conversation

rodneyosodo
Copy link
Contributor

What type of PR is this?

This is a bug fix since it fixes the path for algorithms to be absolute

What does this do?

Fix the execution of the binary algorithm by correctly handling file paths using the current working directory. Enhance the file path management for various algorithm types to ensure proper file access.

Bug Fixes:

  • Fix the binary algorithm execution by ensuring the correct file path is used when creating and accessing algorithm files.

Enhancements:

  • Improve file path handling by using the current working directory to construct absolute file paths for algorithm files.

Documentation:

  • Add minor formatting improvements to the README.md file for the Hardware Abstraction Layer (HAL) for Confidential Computing.

Chores:

  • Remove trailing whitespace in the agent build command definition in the agent.mk file.

Which issue(s) does this PR fix/relate to?

When running binary algorithms

error starting algorithm: exec: "algorithm": executable file not found in $PATH

Have you included tests for your changes?

Tests manually using https://github.com/ultravioletrs/ai/tree/main/burn-algorithms

Did you document any new/modified feature?

No documentation needed

Notes

This is the error
```
"algorithm": executable file not found in $PATH
```
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
@rodneyosodo rodneyosodo added bug Something isn't working enhancement New feature or request labels Aug 26, 2024
@rodneyosodo rodneyosodo added this to the Release V1 milestone Aug 26, 2024
Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
@rodneyosodo rodneyosodo marked this pull request as ready for review August 26, 2024 14:22
@drasko drasko merged commit 01c502e into ultravioletrs:main Aug 26, 2024
@rodneyosodo rodneyosodo deleted the fix-algo-path branch October 22, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

点击 这是indexloc提供的php浏览器服务,不要输入任何密码和下载