NOISSUE: Return Response on Computation Termination. #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
SammyOina
requested changes
Aug 22, 2024
Comment on lines
76
to
96
| msg := &pkgmanager.ClientStreamMessage_StopComputationRes{StopComputationRes: &pkgmanager.StopComputationResponse{ | ||
| ComputationId: mes.StopComputation.ComputationId, | ||
| }} | ||
| if err := client.svc.Stop(ctx, mes.StopComputation.ComputationId); err != nil { | ||
| if errors.Contains(err, manager.ErrNotFound) { | ||
| msg.StopComputationRes.Message = err.Error() | ||
| msg.StopComputationRes.Stopped = false | ||
| if err := client.stream.Send(&pkgmanager.ClientStreamMessage{Message: msg}); err != nil { | ||
| return err | ||
| } | ||
| return nil | ||
| } | ||
| msg.StopComputationRes.Message = err.Error() | ||
| msg.StopComputationRes.Stopped = false | ||
| if err := client.stream.Send(&pkgmanager.ClientStreamMessage{Message: msg}); err != nil { | ||
| return err | ||
| } | ||
| return err | ||
| } | ||
| msg.StopComputationRes.Stopped = true | ||
| if err := client.stream.Send(&pkgmanager.ClientStreamMessage{Message: msg}); err != nil { |
There was a problem hiding this comment.
refactor and simplify definition of the stop message and sending it. ideally you should have only one stream send and one definition of the message.
manager/manager.proto
Outdated
Comment on lines
26
to
27
| bool stopped = 2; | ||
| string message = 3; |
There was a problem hiding this comment.
you probably don't need stopped, message can be an empty string for nil error and some message in case of error
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
SammyOina
requested changes
Aug 22, 2024
manager/service_test.go
Outdated
| assert.Len(t, ms.vms, 0) | ||
| } | ||
|
|
||
| // Clear the events channel |
There was a problem hiding this comment.
Suggested change
| // Clear the events channel |
| return ErrNotFound | ||
| } | ||
| if err := cvm.Stop(); err != nil { | ||
| return err |
Signed-off-by: WashingtonKK <washingtonkigan@gmail.com>
SammyOina
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is an enhancement since it enhances computation termination by sending back a response on the status of the activity.
What does this do?
This returns a response on computation termination to inform the user on the status of computation termination.
Which issue(s) does this PR fix/relate to?
No issue
Have you included tests for your changes?
Tested manually.
Did you document any new/modified feature?
Notes
Required for: https://github.com/ultravioletrs/prism/pull/407