NOISSUE - Start Port Search At Known Port #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When getting free port to be use we start at the minimum port range i.e 6000. This makes the agent url more deterministic since in most cases the agent port will be 6000
The error channel is not used Signed-off-by: Rodney Osodo <socials@rodneyosodo.com>
SammyOina
approved these changes
Aug 19, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds the functionality of having a reproducible agent URL if the minimum port is not taken
What does this do?
Refactor the port-checking logic in the getFreePort function by introducing a new helper function checkPortisFree, which streamlines the process of determining if a port is free and removes redundant error handling.
Which issue(s) does this PR fix/relate to?
No issue
Have you included tests for your changes?
Tested it manually
Did you document any new/modified feature?
No documentation needed
Notes