COCOS-151 - Add compression/decompression option for CLI/Agent #200
Conversation
| "google.golang.org/grpc/metadata" | ||
| ) | ||
|
|
||
| var decompressDataset bool |
There was a problem hiding this comment.
Isn't this compression?
There was a problem hiding this comment.
this states whether to decompress data on arrival or leave it compressed
There was a problem hiding this comment.
➜ cocos git:(cocos-151) ✗ ./build/cocos-cli data ./test/manual/data private.pem -d
2024/08/16 12:29:55 Uploading dataset CSV: ./test/manual/data
Uploading data... 100% [====================================================>]
{"time":"2024-08-16T12:29:55.989831624+03:00","level":"ERROR","msg":"Failed to send Data"}
2024/08/16 12:29:55 Error uploading dataset: rpc error: code = Unknown desc = malformed data, filename does not match manifest
How do you handle and verify file name in this structure since it does not work
Use the base name of the directory, check code to see how directories are handled |
Which scheme, and what does not work? |
base name here will be |
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
What type of PR is this?
This is a feature that allows on the fly compression and decompression
What does this do?
New Features
Bug Fixes
Documentation
Refactor
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
Yes
Notes
# ls /datasets iris.csv