COCOS-181 - Add failed state for algo execution #197
Conversation
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
Signed-off-by: Sammy Oina <sammyoina@gmail.com>
There was a problem hiding this comment.
@SammyOina
What do you think about this:
When a user attempts to fetch results before they are ready, return a warning that results are not ready and do not transition to the next state on the state machine.
Can this also be handled in this PR?
agent already returns results not ready warning. agent will not transition from running state unless results are ready or algo execution failed. |
Failed state exits for two reasons, one is for result consumers to see the reason for failed computation, another is to allow agent to remain in this state after running, it cannot remain in failed state perpetually. i.e running failed is not an actual state. agent state machine is still running. see https://github.com/SammyOina/cocos-ai/blob/cocos-181/agent/state.go |
What type of PR is this?
This a feature as it adds a new failed state to agent
What does this do?
New Features
Improvements
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
Will update cocos docs
Notes